-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stats: disable EXPECT_EQ in memory integration test #12239
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until a real solution for #12209 is found.: Signed-off-by: Matt Klein <mklein@lyft.com>
antoniovicente
previously approved these changes
Jul 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking quick action against flakes.
…ration_test Signed-off-by: Matt Klein <mklein@lyft.com>
jmarantz
previously approved these changes
Jul 23, 2020
mattklein123
dismissed stale reviews from jmarantz and antoniovicente
via
July 23, 2020 00:18
7a26264
mattklein123
changed the title
stats: disable memory integration test
stats: disable EXPECT_EQ in memory integration test
Jul 23, 2020
jmarantz
approved these changes
Jul 23, 2020
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
KBaichoo
pushed a commit
to KBaichoo/envoy
that referenced
this pull request
Jul 30, 2020
Until a real solution for envoyproxy#12209 is found.: Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
chaoqin-li1123
pushed a commit
to chaoqin-li1123/envoy
that referenced
this pull request
Aug 7, 2020
Until a real solution for envoyproxy#12209 is found.: Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: chaoqinli <chaoqinli@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until a real solution for #12209
is found.
Risk Level: None
Testing: N/A
Docs Changes: N/A
Release Notes: N/A