Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: disable EXPECT_EQ in memory integration test #12239

Merged
merged 3 commits into from
Jul 23, 2020

Conversation

mattklein123
Copy link
Member

Until a real solution for #12209
is found.

Risk Level: None
Testing: N/A
Docs Changes: N/A
Release Notes: N/A

Until a real solution for #12209
is found.:

Signed-off-by: Matt Klein <mklein@lyft.com>
@mattklein123
Copy link
Member Author

cc @jmarantz @antoniovicente

Signed-off-by: Matt Klein <mklein@lyft.com>
antoniovicente
antoniovicente previously approved these changes Jul 23, 2020
Copy link
Contributor

@antoniovicente antoniovicente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking quick action against flakes.

…ration_test

Signed-off-by: Matt Klein <mklein@lyft.com>
jmarantz
jmarantz previously approved these changes Jul 23, 2020
@mattklein123 mattklein123 changed the title stats: disable memory integration test stats: disable EXPECT_EQ in memory integration test Jul 23, 2020
@jmarantz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mattklein123 mattklein123 merged commit e1d7d8e into master Jul 23, 2020
@mattklein123 mattklein123 deleted the disable_stats_integration_test branch July 23, 2020 02:40
KBaichoo pushed a commit to KBaichoo/envoy that referenced this pull request Jul 30, 2020
Until a real solution for envoyproxy#12209
is found.:

Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
chaoqin-li1123 pushed a commit to chaoqin-li1123/envoy that referenced this pull request Aug 7, 2020
Until a real solution for envoyproxy#12209
is found.:

Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: chaoqinli <chaoqinli@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants