Skip to content

Commit

Permalink
stats: disable EXPECT_EQ in memory integration test (#12239)
Browse files Browse the repository at this point in the history
Until a real solution for #12209
is found.:

Signed-off-by: Matt Klein <mklein@lyft.com>
  • Loading branch information
mattklein123 authored Jul 23, 2020
1 parent 0a0fc51 commit e1d7d8e
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions test/integration/stats_integration_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,8 @@ TEST_P(ClusterMemoryTestRunner, MemoryLargeClusterSizeWithFakeSymbolTable) {
// We only run the exact test for ipv6 because ipv4 in some cases may allocate a
// different number of bytes. We still run the approximate test.
if (ip_version_ != Network::Address::IpVersion::v6) {
EXPECT_MEMORY_EQ(m_per_cluster, 44811);
// https://github.com/envoyproxy/envoy/issues/12209
// EXPECT_MEMORY_EQ(m_per_cluster, 44811);
}
EXPECT_MEMORY_LE(m_per_cluster, 46000); // Round up to allow platform variations.
}
Expand Down Expand Up @@ -379,7 +380,8 @@ TEST_P(ClusterMemoryTestRunner, MemoryLargeClusterSizeWithRealSymbolTable) {
// We only run the exact test for ipv6 because ipv4 in some cases may allocate a
// different number of bytes. We still run the approximate test.
if (ip_version_ != Network::Address::IpVersion::v6) {
EXPECT_MEMORY_EQ(m_per_cluster, 36923);
// https://github.com/envoyproxy/envoy/issues/12209
// EXPECT_MEMORY_EQ(m_per_cluster, 36923);
}
EXPECT_MEMORY_LE(m_per_cluster, 38000); // Round up to allow platform variations.
}
Expand Down Expand Up @@ -426,7 +428,8 @@ TEST_P(ClusterMemoryTestRunner, MemoryLargeHostSizeWithStats) {
// We only run the exact test for ipv6 because ipv4 in some cases may allocate a
// different number of bytes. We still run the approximate test.
if (ip_version_ != Network::Address::IpVersion::v6) {
EXPECT_MEMORY_EQ(m_per_host, 1380);
// https://github.com/envoyproxy/envoy/issues/12209
// EXPECT_MEMORY_EQ(m_per_host, 1380);
}
EXPECT_MEMORY_LE(m_per_host, 1800); // Round up to allow platform variations.
}
Expand Down

0 comments on commit e1d7d8e

Please sign in to comment.