Skip to content

Commit

Permalink
tooling: Remove (default) remote_download_all flags (#21733)
Browse files Browse the repository at this point in the history
the flag is no longer experimental, and the default is what we
are setting it to.

Signed-off-by: Ryan Northey <ryan@synca.io>
  • Loading branch information
phlax authored Jun 17, 2022
1 parent 2b2a08b commit 8672554
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
4 changes: 0 additions & 4 deletions bazel/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -310,10 +310,6 @@ bazel build envoy --config=remote-clang \
Change the value of `--remote_cache`, `--remote_executor` and `--remote_instance_name` for your remote build services. Tests can
be run in remote execution too.
Note: Currently the test run configuration in `.bazelrc` doesn't download test binaries and test logs,
to override the behavior set [`--experimental_remote_download_outputs`](https://docs.bazel.build/versions/master/command-line-reference.html#flag--experimental_remote_download_outputs)
accordingly.
## Building Envoy with Docker sandbox
Building Envoy with Docker sandbox uses the same Docker image used in CI with fixed C++ toolchain configuration. It produces more consistent
Expand Down
3 changes: 0 additions & 3 deletions tools/proto_format/proto_format.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@ read -ra BAZEL_BUILD_OPTIONS <<< "${BAZEL_BUILD_OPTIONS:-}"
# Generate //versioning:active_protos.
./tools/proto_format/active_protos_gen.py ./api > ./api/versioning/BUILD

# This is for local RBE setup, should be no-op for builds without RBE setting in bazelrc files.
BAZEL_BUILD_OPTIONS+=("--remote_download_outputs=all")

# If the specified command is 'freeze', we tell protoxform to adjust package version status to
# reflect a major version freeze and then do a regular 'fix'.
PROTO_SYNC_CMD="$1"
Expand Down

0 comments on commit 8672554

Please sign in to comment.