tooling: Remove (default) remote_download_outputs flags
#21733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the flag is no longer experimental, and the default is what we are setting it to. Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
changed the title
remote_download_all flagsremote_download_outputs flags
keith
approved these changes
Jun 17, 2022
lizan
reviewed
Jun 17, 2022
| @@ -23,9 +23,6 @@ read -ra BAZEL_BUILD_OPTIONS <<< "${BAZEL_BUILD_OPTIONS:-}" | |||
| # Generate //versioning:active_protos. | |||
| ./tools/proto_format/active_protos_gen.py ./api > ./api/versioning/BUILD | |||
|
|
|||
| # This is for local RBE setup, should be no-op for builds without RBE setting in bazelrc files. | |||
| BAZEL_BUILD_OPTIONS+=("--remote_download_outputs=all") | |||
There was a problem hiding this comment.
Did you verify with local RBE setup?
There was a problem hiding this comment.
i dont have that - but i did check the docs
There was a problem hiding this comment.
There was a problem hiding this comment.
Bazel's default is irrelevant, this is to override what we specifies in .bazelrc: https://github.com/envoyproxy/envoy/blob/main/.bazelrc#L246
There was a problem hiding this comment.
my bad - ill revert and update docs
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Jun 20, 2022
…envoyproxy#21733)" This partially reverts commit 8672554. Signed-off-by: Ryan Northey <ryan@synca.io>
Amila-Rukshan
pushed a commit
to Amila-Rukshan/envoy
that referenced
this pull request
Jun 28, 2022
the flag is no longer experimental, and the default is what we are setting it to. Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Amila Senadheera <amila.15@cse.mrt.ac.lk>
Amila-Rukshan
pushed a commit
to Amila-Rukshan/envoy
that referenced
this pull request
Jun 28, 2022
…envoyproxy#21733)" (envoyproxy#21776) This partially reverts commit 8672554. Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Amila Senadheera <amila.15@cse.mrt.ac.lk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the flag is no longer experimental, and the default is what we
are setting it to.
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]