-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tooling: Remove (default) remote_download_outputs
flags
#21733
Conversation
the flag is no longer experimental, and the default is what we are setting it to. Signed-off-by: Ryan Northey <ryan@synca.io>
remote_download_all
flagsremote_download_outputs
flags
@@ -23,9 +23,6 @@ read -ra BAZEL_BUILD_OPTIONS <<< "${BAZEL_BUILD_OPTIONS:-}" | |||
# Generate //versioning:active_protos. | |||
./tools/proto_format/active_protos_gen.py ./api > ./api/versioning/BUILD | |||
|
|||
# This is for local RBE setup, should be no-op for builds without RBE setting in bazelrc files. | |||
BAZEL_BUILD_OPTIONS+=("--remote_download_outputs=all") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you verify with local RBE setup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont have that - but i did check the docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bazel's default is irrelevant, this is to override what we specifies in .bazelrc: https://github.com/envoyproxy/envoy/blob/main/.bazelrc#L246
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my bad - ill revert and update docs
…envoyproxy#21733)" This partially reverts commit 8672554. Signed-off-by: Ryan Northey <ryan@synca.io>
the flag is no longer experimental, and the default is what we are setting it to. Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Amila Senadheera <amila.15@cse.mrt.ac.lk>
…envoyproxy#21733)" (envoyproxy#21776) This partially reverts commit 8672554. Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Amila Senadheera <amila.15@cse.mrt.ac.lk>
the flag is no longer experimental, and the default is what we
are setting it to.
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]