tools: fix source mapping #2429
Conversation
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
.bazelrc
Outdated
| @@ -40,6 +40,7 @@ build --java_language_version=8 | |||
| # Override PGV validation with NOP functions | |||
| build --@com_envoyproxy_protoc_gen_validate//bazel:template-flavor=nop | |||
|
|
|||
| build:dbg --compilation_mode=debug | |||
There was a problem hiding this comment.
isn't it --compilation_mode=dbg?
There was a problem hiding this comment.
yes... thank you for catching this.
There was a problem hiding this comment.
(I think that for whatever reason both work since the change from debug -> dbg did not result in a rebuild of the project)
There was a problem hiding this comment.
hrm don't think so:
--compilation_mode=daf
ERROR: While parsing option --compilation_mode=daf: Not a valid compilation mode: 'daf' (should be fastbuild, dbg or opt)
are you sure it's getting picked up?
There was a problem hiding this comment.
Mhm... looking into this.
There was a problem hiding this comment.
It's not picked up it seems. This is what I see in the console when I click "Debug" in Android Studio:
Command: /Users/raugustyniak/src/envoy-mobile/bazelw build --tool_tag=ijwb:AndroidStudio --output_groups=+android_deploy_info --curses=no --color=yes --progress_in_terminal_title=no --config=dbg --fat_apk_cpu=arm64-v8a --fission=no -c dbg --build_event_binary_file=/var/folders/0x/1rsd77td52188p67fnqhm36r0000gn/T/intellij-bep-482ec217-a27f-49c5-bfd5-3374b78b57ab --nobuild_event_binary_file_path_conversion -- //examples/kotlin/hello_world:hello_envoy_kt
-c dbg is there even if I explicitly set --compilation_mode to other value in my .bazelrc file.
There was a problem hiding this comment.
Yea that's because android studio's bazel plugin is adding -c dbg when you hit the lil debug icon and is overriding your compilation mode, so I presume you can set any garbage and it won't fail because it'll get overriden
There was a problem hiding this comment.
ah, got it - makes sense. Thank you for the context.
In that case, I am going to keep --compilation_mode=dbg for cases when we want to use --config=dbg from outside of the debugging flow in Android Studio UI.
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
* main: tools: fix source mapping (#2429) Update Envoy (#2427) tools: add arm64 debug run configuration (#2424) Revert "docs: use sphinx githubpages extension (#2418)" (#2425) Remove Tulsi configuration & docs (#2421) Fix isCleartextTrafficPermitted (#2420) Squelch two JNI build warnings (#2426) dns: allow using the `getaddrinfo`-based system DNS resolver (#2419) docs: use sphinx githubpages extension (#2418) Update Envoy (#2417) Remove rules_cc uses Bump Lyft Support Rotation (#2414) iOS: fix retain cycles in `EnvoyNetworkMonitor` (#2415) Update Envoy (#2413) engine: remove outdated comment about `registerFactories()` (#2412) api: make RequestTrailersBuilder and ResponseHeadersBuilder constructors public (#2410) Signed-off-by: JP Simard <jp@jpsim.com>
Description: Per our documentation, the following should be true "While breaking on a C++ function, Android Studio should present the source file and highlight the line where the breakpoint hit with all scope information". That feature did not work - I didn't confirm this but it's possible that the functionality was broken when #2184 was merged. Anyway, the issue was that
envoy-mobile/.bazelrc
Line 44 in 581ba40
--config=dbgsetting explicitly.Risk Level: None
Testing: Confirmed that Android Studio opens the right file (and highlights the right line) when EnvoyMobile breakpoint is hit.
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Rafal Augustyniak raugustyniak@lyft.com