iOS: fix retain cycles in EnvoyNetworkMonitor
#2415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And properly clean up reachability ref. Signed-off-by: JP Simard <jp@jpsim.com>
Augustyniak
approved these changes
Jul 13, 2022
| @@ -38,6 +43,7 @@ - (void)startPathMonitor { | |||
| nw_path_monitor_set_queue(_path_monitor, queue); | |||
|
|
|||
| __block envoy_network_t previousNetworkType = -1; | |||
| envoy_engine_t engineHandle = _engineHandle; | |||
There was a problem hiding this comment.
It was causing a retain cycle in the nw update block.
jpsim
added a commit
that referenced
this pull request
Jul 18, 2022
* main: tools: fix source mapping (#2429) Update Envoy (#2427) tools: add arm64 debug run configuration (#2424) Revert "docs: use sphinx githubpages extension (#2418)" (#2425) Remove Tulsi configuration & docs (#2421) Fix isCleartextTrafficPermitted (#2420) Squelch two JNI build warnings (#2426) dns: allow using the `getaddrinfo`-based system DNS resolver (#2419) docs: use sphinx githubpages extension (#2418) Update Envoy (#2417) Remove rules_cc uses Bump Lyft Support Rotation (#2414) iOS: fix retain cycles in `EnvoyNetworkMonitor` (#2415) Update Envoy (#2413) engine: remove outdated comment about `registerFactories()` (#2412) api: make RequestTrailersBuilder and ResponseHeadersBuilder constructors public (#2410) Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And properly clean up reachability ref.
Risk Level: Low
Testing: Validated using the memory graph debugger in Xcode with both reachability and path monitor modes
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: JP Simard jp@jpsim.com