-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't trigger codecov reports #1109
Conversation
… useful information.
Thanks. There is one from |
Thanks, fixed. I wonder whether the dual reports could be part of what's confusing codecov.io. Someday we should try to re-implement and make this useful. But not today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@@ -20,11 +20,8 @@ install: | |||
- install-edm-windows.cmd | |||
- edm install -y wheel click coverage | |||
- edm run -- python etstool.py install --runtime=%runtime% | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drive-by spacing consistency nitpick
Codecov Report
@@ Coverage Diff @@
## master #1109 +/- ##
==========================================
- Coverage 76.15% 74.18% -1.98%
==========================================
Files 54 79 +25
Lines 6493 8479 +1986
Branches 1263 1610 +347
==========================================
+ Hits 4945 6290 +1345
- Misses 1205 1810 +605
- Partials 343 379 +36
Continue to review full report at Codecov.
|
AAARGH! |
Hmmm, that's puzzling. |
Maybe because master still has the codecov setup, this needs to be merged first for this to take effect? |
(it was a baseless wild guess) |
No idea. Let's merge and see what happens. |
This PR removes the codecov triggers from the Travis CI configuration.
Fixes #919