Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider ditching coverage #919

Closed
mdickinson opened this issue Mar 3, 2020 · 1 comment · Fixed by #1109
Closed

Consider ditching coverage #919

mdickinson opened this issue Mar 3, 2020 · 1 comment · Fixed by #1109
Labels
component: test suite Issues related directly to the test suite

Comments

@mdickinson
Copy link
Member

The codecov.io comments aren't currently being useful: they tend to report coverage diffs in unrelated files. It may make sense to ditch the coverage reports.

See for example #917, which reports coverage changes in unrelated files.

Core Python is currently having a similar discussion. See https://bugs.python.org/issue39704
@mdickinson mdickinson added the component: test suite Issues related directly to the test suite label Mar 3, 2020
@kitchoi
Copy link
Contributor

kitchoi commented May 19, 2020

This is still an issue as of today...e.g. #1102 (comment)

I think I have been ignoring codecov :/

@mdickinson mdickinson mentioned this issue May 19, 2020
Merged
@kitchoi kitchoi mentioned this issue Sep 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: test suite Issues related directly to the test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't trigger codecov reports enthought/traits
2 participants
@mdickinson @kitchoi