-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .travis.yml for Qt #529
Conversation
FWIW, here's the fix for this issue that worked for Envisage: enthought/envisage#287 |
Yep. Was trying to see whether other alternatives would work as parallel experiments. Enable does this differently too 😂 |
Right, I'm not fond of the Envisage solution, and would be interested in better alternatives. |
It looks as though you're being bitten by this: https://github.com/enthought/buildsystem/issues/3178 |
Looks like updating the OSX image fixed this. The libxml on the default OSX image was too old for the Qt version we are using. I have been manually terminating other builds not relevant to my testing so I could focus on one thing at a time :) |
Correction: The build actually failed, but that failure was caused by an assertion error in test. That is orthogonal to the objective of this draft PR. The entire test suite had been run. |
Codecov Report
@@ Coverage Diff @@
## master #529 +/- ##
==========================================
- Coverage 37.08% 36.99% -0.09%
==========================================
Files 470 470
Lines 26027 26027
Branches 3961 3961
==========================================
- Hits 9652 9629 -23
- Misses 15948 15977 +29
+ Partials 427 421 -6
Continue to review full report at Codecov.
|
History of changes for future reference:
|
If it is okay, I would propose doing a squash-and-merge for this PR. Many of the commits are experimental, messy and possibly confusing when read on its own. I hope the comment above will provide the history needed for future references. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
It seems possible that the need to specify a particular OS X image could be reverted once the buildsystem issue is solved.
👍 |
Thank you! Squashing and merging...
Agreed. |
* Update .travis.yml to include libglu1-mesa-dev for Qt * Restore libxkbcommon-x11 and move other dependencies up * Fix package name for libsdl * Add a debug flag * Add libxcb-iccm4 * Continue the same exercise for pyside2, add libxcb-image * Giving up - let's use the same packages * Add libxml2 for osx image * Use brew manually See https://travis-ci.community/t/macos-build-fails-because-of-homebrew-bundle-unknown-command/7296/28 * Try a newer osx image * Add a comment * Is libdbus still needed? * Remove debugging flag - it is noisy and is embedded in between tests
* Fix errors from incorrect QImage memory management. (#546) This should stop the sporadic test failures caused by referencing memory which has been freed and used by something else. The fix is to attach the numpy array with the allocated memory to the QImage, so that the lifetime of the array is at least as long as that of the QImage. * Fix dock pane layout (#545) * Provide sizeHint to QWidget * REF : Restore qt4 conditional branch modified: pyface/ui/qt4/tasks/main_window_layout.py * TST: Test Qt dock widget has the correct size (#552) Co-authored-by: Sai Rahul Poruri <rporuri@enthought.com> Co-authored-by: Kit Choi <kitchoi@users.noreply.github.com> * Update Changelog for 7.0.1 * Remove master only setting on Travis and Appveyor which prevent bug fix release PR from building * Update .travis.yml for Qt (#529) * Update .travis.yml to include libglu1-mesa-dev for Qt * Restore libxkbcommon-x11 and move other dependencies up * Fix package name for libsdl * Add a debug flag * Add libxcb-iccm4 * Continue the same exercise for pyside2, add libxcb-image * Giving up - let's use the same packages * Add libxml2 for osx image * Use brew manually See https://travis-ci.community/t/macos-build-fails-because-of-homebrew-bundle-unknown-command/7296/28 * Try a newer osx image * Add a comment * Is libdbus still needed? * Remove debugging flag - it is noisy and is embedded in between tests * Update install command for installing wx to match master (this is equivalent to a merge of a couple of PRs Co-authored-by: Corran Webster <cwebster@enthought.com> Co-authored-by: Pedro Rivotti <44579232+pedrorivotti@users.noreply.github.com> Co-authored-by: Sai Rahul Poruri <rporuri@enthought.com>
CI is currently failing with this error:
This PR attempts to fix this.