-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI failures on Linux, Windows #287
Conversation
Relevant output:
|
Adding these packages one-by-one cannot possibly be the right way to solve this problem. |
Ready for review. I'm going to leave the |
Codecov Report
@@ Coverage Diff @@
## master #287 +/- ##
=======================================
Coverage 53.75% 53.75%
=======================================
Files 135 135
Lines 4394 4394
Branches 511 511
=======================================
Hits 2362 2362
Misses 1990 1990
Partials 42 42 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
FTR, looks like the package versions used in CI are - pyqt5 v 5.14.2 (edm package) and pyside2 5.15.0 (pypi wheel). |
This PR fixes independent CI failures on Linux and Windows
The continuous integration is unhappy again on Linux. This is a debugging PR intended to help track down what's wrong.