Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI failures on Linux, Windows #287

Merged
merged 9 commits into from
Jun 1, 2020
Merged

Conversation

mdickinson
Copy link
Member

@mdickinson mdickinson commented Jun 1, 2020

This PR fixes independent CI failures on Linux and Windows

  • On Windows, force use of VS 2019, to avoid a test hang due to a bluetooth-related popup from PyQt5.
  • On Linux, make sure necessary libxcb-* packages are installed.

The continuous integration is unhappy again on Linux. This is a debugging PR intended to help track down what's wrong.

@mdickinson
Copy link
Member Author

Relevant output:

Got keys from plugin meta data ("xcb")
QFactoryLoader::QFactoryLoader() checking directory path "/home/travis/.edm/envs/envisage-test-3.6-pyside2/bin/platforms" ...
Cannot load library /home/travis/.edm/envs/envisage-test-3.6-pyside2/lib/python3.6/site-packages/PySide2/Qt/plugins/platforms/libqxcb.so: (libxcb-icccm.so.4: cannot open shared object file: No such file or directory)
QLibraryPrivate::loadPlugin failed on "/home/travis/.edm/envs/envisage-test-3.6-pyside2/lib/python3.6/site-packages/PySide2/Qt/plugins/platforms/libqxcb.so" : "Cannot load library /home/travis/.edm/envs/envisage-test-3.6-pyside2/lib/python3.6/site-packages/PySide2/Qt/plugins/platforms/libqxcb.so: (libxcb-icccm.so.4: cannot open shared object file: No such file or directory)"
qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found.
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

@mdickinson
Copy link
Member Author

Adding these packages one-by-one cannot possibly be the right way to solve this problem.

@mdickinson mdickinson marked this pull request as ready for review June 1, 2020 09:18
@mdickinson
Copy link
Member Author

Ready for review. I'm going to leave the QT_DEBUG_PLUGINS variable in, to save time next time we have to debug something similar.

@mdickinson mdickinson changed the title Set debug e-var to track down CI failures on Linux Fix CI failures on Linux, Windows Jun 1, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2020

Codecov Report

Merging #287 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #287   +/-   ##
=======================================
  Coverage   53.75%   53.75%           
=======================================
  Files         135      135           
  Lines        4394     4394           
  Branches      511      511           
=======================================
  Hits         2362     2362           
  Misses       1990     1990           
  Partials       42       42           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45b43da...e3f7f59. Read the comment docs.

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rahulporuri
Copy link
Contributor

FTR, looks like the package versions used in CI are - pyqt5 v 5.14.2 (edm package) and pyside2 5.15.0 (pypi wheel).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants