Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose more arguments to confirm function #1221

Merged
merged 3 commits into from
Mar 17, 2023
Merged

Expose more arguments to confirm function #1221

merged 3 commits into from
Mar 17, 2023

Commits on Mar 14, 2023

  1. Reflect more arguments in confirm method.

    @corranwebster
    corranwebster committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    5ba8a25 View commit details
    Browse the repository at this point in the history

  2. And tests for new arguments.

    @corranwebster
    corranwebster committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    983b713 View commit details
    Browse the repository at this point in the history

  3. Use correct return code 

    Not 100% sure that this return code is possible in user interaction, but the
return code isn't the point of the test, the argument tracking is.
    @corranwebster
    corranwebster committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    c5f9224 View commit details
    Browse the repository at this point in the history