Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose more arguments to confirm function #1221

Merged
merged 3 commits into from
Mar 17, 2023
Merged

Expose more arguments to confirm function #1221

merged 3 commits into from
Mar 17, 2023

Conversation

corranwebster
Copy link
Contributor

Fixes #1009

@corranwebster
Reflect more arguments in confirm method.
5ba8a25
@corranwebster
And tests for new arguments.
983b713
@corranwebster
Use correct return code
c5f9224 
Not 100% sure that this return code is possible in user interaction, but the
return code isn't the point of the test, the argument tracking is.
mdickinson
mdickinson approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corranwebster corranwebster merged commit 44ec41e into main Mar 17, 2023
@corranwebster corranwebster deleted the enh/confirmation-dialog-args branch March 17, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdickinson mdickinson mdickinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confirm function is missing parameters
2 participants
@corranwebster @mdickinson