Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #1036

Merged
merged 34 commits into from
Apr 18, 2023
Merged

Fix CI #1036

merged 34 commits into from
Apr 18, 2023

Conversation

corranwebster
Copy link
Contributor

@corranwebster corranwebster commented Apr 17, 2023 •
edited
Loading

This gets a reasonable baseline CI working for Kiva and Enable. It covers Python 3.8 and 3.10 with a reasonable set of Kiva backends and ETS toolkits. It splits out the Linux Qt dependency installation into a separate action as is done in other ETS projects so it can be re-used across workflows.

There are a number of test cases skipped:

This also adds a skip to a Cairo backend test case due to #1035 and a couple of drive-by fixes to the Cairo Kiva backend (Cairo was previously not being tested).

@corranwebster
Add testing with pip; remove MacOS EDM tests.
4489ee7
@corranwebster
Versions are strings.
30212a0
@corranwebster
Actuall install toolkits!
ff405a6
@corranwebster
Use pyface.ui.qt4 imports for now.
114ba74
@corranwebster
Celiagg isn't special
738257b
@corranwebster
Ranges should be ints.
a2a2a33
@corranwebster
And position of scrollbar should also be an int.
fda6961
@corranwebster
Revert change to ScrollbarRange; fix linux dependencies.
f75598f
@corranwebster
Merge branch 'main' into fix/update-ci
5fe2e2a
@corranwebster
Didtch PyQt5 for now.
f79c8fe
@corranwebster
Add support for cairo tests.
a1f0df0
@corranwebster
Fix typo in cairo backend
cccb89e
@corranwebster
Fix quad Bezier on Cairo backend.
90e5bf8
@corranwebster
Expect Cairo drawing to fail -see #1035
9819033
@corranwebster
Improve workflow and update steuptools version.
6cd6b3f
@corranwebster
Separate celiagg install.
6818f41
@corranwebster
Add Mac (celiagg may be problematic).
5d8332d
@corranwebster
Different tests for linux vs. not linux
9ffd788 
Only use xvfb on Linu
@corranwebster
Some fixes for test running in OS X and Windows
e16faff
@corranwebster
Add windows to test matrix.
53c9e7a
@corranwebster corranwebster mentioned this pull request Apr 18, 2023
Closed
@corranwebster corranwebster marked this pull request as ready for review April 18, 2023 10:31
@corranwebster
Copy link
Contributor Author

For reviewer: run of bleeding edge tests against this branch. https://github.com/enthought/enable/actions/runs/4731925723

corranwebster
corranwebster commented Apr 18, 2023
View reviewed changes
kiva/cairo.py Outdated Show resolved Hide resolved
jwiggins
jwiggins approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@jwiggins jwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed quotes make me itch a little, but I don't really care since this project is currently dying of bit rot.

.github/workflows/bleeding-edge.yml Outdated Show resolved Hide resolved
enable/__init__.py Outdated Show resolved Hide resolved
@corranwebster corranwebster merged commit 1565976 into main Apr 18, 2023
@corranwebster corranwebster deleted the fix/update-ci-v2 branch April 18, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwiggins jwiggins jwiggins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corranwebster @jwiggins