Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyQt5 on Python 3.10 doesn't cast float to int #1037

Closed
corranwebster opened this issue Apr 18, 2023 · 0 comments · Fixed by #1041
Closed

PyQt5 on Python 3.10 doesn't cast float to int #1037

corranwebster opened this issue Apr 18, 2023 · 0 comments · Fixed by #1041

Comments

@corranwebster
Copy link
Contributor

This is due to https://bugs.python.org/issue36048 (most likely). We should probably be doing explicit casts to int in affected calls, since that was what was happening anyway.
This was referenced Apr 18, 2023
Merged
Merged
corranwebster added a commit that referenced this issue Apr 18, 2023
@corranwebster
Fix CI (#1036)
1565976 
This gets a reasonable baseline CI working for Kiva and Enable.  It covers Python 3.8 and 3.10 with a reasonable set of Kiva backends and ETS toolkits.  It splits out the Linux Qt dependency installation into a separate action as is done in other ETS projects so it can be re-used across workflows.

There are a number of test cases skipped:

- WxPython on MacOS and Linux due to lack of appropriate wheels
- PyQt5 on Python 3.10 due to #1037
- PyQt5 on Windows due to #1038

This also adds a skip to a Cairo backend test case due to #1035 and a couple of drive-by fixes to the Cairo Kiva backend (Cairo was previously not being tested).
corranwebster added a commit that referenced this issue Apr 18, 2023
@corranwebster
Add explicit float -> int conversion for Qt (#1041)
6135fea 
This was happening implicitly until https://bugs.python.org/issue36048 This makes it explicit, which means things should work with PyQt5 on Python 3.10.

Fixes #1037
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add explicit float -> int conversion for Qt enthought/enable
1 participant
@corranwebster