Skip to content

Conversation

@igorovh
Copy link
Member

@igorovh igorovh commented Oct 28, 2025

No description provided.

igorovh and others added 5 commits October 27, 2025 23:39
* feat: add experimental tab
Bumps the npm_and_yarn group with 1 update in the / directory: [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite).


Updates `vite` from 6.3.5 to 7.1.11
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v7.1.11/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-version: 7.1.11
  dependency-type: direct:development
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* add channel section toggle feature for Kick and Twitch platforms

* Apply suggestion from @igorovh

* Apply suggestion from @igorovh

---------

Co-authored-by: igor <37638480+igorovh@users.noreply.github.com>
* fix: update live video check to handle infinite duration

* Update src/platforms/kick/kick.utils.ts

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* remove unused var

* fixes for latency

---------

Co-authored-by: igor <37638480+igorovh@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: igorovh <xoxo@igor.ovh>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @igorovh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on a routine version bump and comprehensive dependency updates to ensure the project uses the latest stable packages. A significant new feature, the 'Channel Section' for both Kick and Twitch, has been introduced, allowing users to toggle a section displaying watch time and quick access links. Additionally, the settings interface has been expanded with an 'Experimental' tab, and minor logic improvements were made to live video detection and stream latency calculation.

Highlights

  • Version Update: The project version has been updated from 5.1.15 to 5.1.17 across package.json and package-lock.json.
  • Dependency Updates: Numerous dependencies have been updated, including vite (from 7.0.5 to 7.1.11), @preact/preset-vite, magic-string, sourcemap-codec, css-select, css-what, fdir, tinyglobby, vite-plugin-generate-file, vite-prerender-plugin, and postcss. New dependencies like graphql-tag and jszip were also introduced, and many dev: true flags were added to existing dependencies in package-lock.json.
  • New 'Channel Section' Feature: A new configurable setting, channelSection, has been added for both Kick and Twitch platforms. This setting controls the visibility of a dedicated 'Channel Section' that provides watch time information and quick access links.
  • Experimental Settings Tab: A new 'Experimental' tab, complete with a new SVG icon, has been introduced to the settings UI for both Kick and Twitch, providing a dedicated space for experimental features.
  • Improved Live Video Detection: The logic for detecting live videos on Kick has been refined to check for Number.POSITIVE_INFINITY as the video duration, replacing a previously fixed constant.
  • Stream Latency Module Enhancement: The Kick Stream Latency module now includes a check to ensure the video is not paused before updating the latency counter, preventing inaccurate readings when the stream is not actively playing.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@igorovh igorovh merged commit 91d7322 into master Oct 28, 2025
1 check passed
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the version to 5.1.17 and includes several dependency updates. It also introduces a new 'Channel Section' feature for both Kick and Twitch platforms, which is controlled by a new setting. I appreciate the refactoring in the settings modules to improve type safety and maintainability by removing magic numbers for tab indices. The fix for live video detection on Kick is also a good improvement. I've added a couple of suggestions to further enhance type safety in the newly refactored settings code.

},
];
] as const;
const tabIndexes = Object.fromEntries(this.SETTINGS_TABS.map((tab, index) => [tab.title, index]));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve type safety and leverage the as const assertion on SETTINGS_TABS, you can add a type assertion to tabIndexes. This will ensure that any typos when accessing tab indexes (e.g., tabIndexes.Genral) are caught at compile time.

Suggested change
const tabIndexes = Object.fromEntries(this.SETTINGS_TABS.map((tab, index) => [tab.title, index]));
const tabIndexes = Object.fromEntries(this.SETTINGS_TABS.map((tab, index) => [tab.title, index])) as Record<(typeof this.SETTINGS_TABS)[number]["title"], number>;

},
];
] as const;
const tabIndexes = Object.fromEntries(this.SETTINGS_TABS.map((tab, index) => [tab.title, index]));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve type safety and leverage the as const assertion on SETTINGS_TABS, you can add a type assertion to tabIndexes. This will ensure that any typos when accessing tab indexes (e.g., tabIndexes.Genral) are caught at compile time.

Suggested change
const tabIndexes = Object.fromEntries(this.SETTINGS_TABS.map((tab, index) => [tab.title, index]));
const tabIndexes = Object.fromEntries(this.SETTINGS_TABS.map((tab, index) => [tab.title, index])) as Record<(typeof this.SETTINGS_TABS)[number]["title"], number>;

@igorovh igorovh deleted the dev branch October 29, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants