-
Notifications
You must be signed in to change notification settings - Fork 21
release: version 5.1.17 #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* feat: add experimental tab
Bumps the npm_and_yarn group with 1 update in the / directory: [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite). Updates `vite` from 6.3.5 to 7.1.11 - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v7.1.11/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 7.1.11 dependency-type: direct:development dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: update live video check to handle infinite duration * Update src/platforms/kick/kick.utils.ts Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * remove unused var * fixes for latency --------- Co-authored-by: igor <37638480+igorovh@users.noreply.github.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: igorovh <xoxo@igor.ovh>
Summary of ChangesHello @igorovh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on a routine version bump and comprehensive dependency updates to ensure the project uses the latest stable packages. A significant new feature, the 'Channel Section' for both Kick and Twitch, has been introduced, allowing users to toggle a section displaying watch time and quick access links. Additionally, the settings interface has been expanded with an 'Experimental' tab, and minor logic improvements were made to live video detection and stream latency calculation. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request bumps the version to 5.1.17 and includes several dependency updates. It also introduces a new 'Channel Section' feature for both Kick and Twitch platforms, which is controlled by a new setting. I appreciate the refactoring in the settings modules to improve type safety and maintainability by removing magic numbers for tab indices. The fix for live video detection on Kick is also a good improvement. I've added a couple of suggestions to further enhance type safety in the newly refactored settings code.
| }, | ||
| ]; | ||
| ] as const; | ||
| const tabIndexes = Object.fromEntries(this.SETTINGS_TABS.map((tab, index) => [tab.title, index])); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To improve type safety and leverage the as const assertion on SETTINGS_TABS, you can add a type assertion to tabIndexes. This will ensure that any typos when accessing tab indexes (e.g., tabIndexes.Genral) are caught at compile time.
| const tabIndexes = Object.fromEntries(this.SETTINGS_TABS.map((tab, index) => [tab.title, index])); | |
| const tabIndexes = Object.fromEntries(this.SETTINGS_TABS.map((tab, index) => [tab.title, index])) as Record<(typeof this.SETTINGS_TABS)[number]["title"], number>; |
| }, | ||
| ]; | ||
| ] as const; | ||
| const tabIndexes = Object.fromEntries(this.SETTINGS_TABS.map((tab, index) => [tab.title, index])); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To improve type safety and leverage the as const assertion on SETTINGS_TABS, you can add a type assertion to tabIndexes. This will ensure that any typos when accessing tab indexes (e.g., tabIndexes.Genral) are caught at compile time.
| const tabIndexes = Object.fromEntries(this.SETTINGS_TABS.map((tab, index) => [tab.title, index])); | |
| const tabIndexes = Object.fromEntries(this.SETTINGS_TABS.map((tab, index) => [tab.title, index])) as Record<(typeof this.SETTINGS_TABS)[number]["title"], number>; |
No description provided.