Skip to content

Conversation

@maksPodstawski
Copy link
Member

Description

Briefly explain what this PR does. Is it a bug fix, new feature, or a refactor?

Testing

Select all the environments you tested this PR with:

Twitch

  • BetterTTV (BTTV)
  • FrankerFaceZ (FFZ)
  • 7TV
  • Native Twitch

Kick

  • 7TV
  • Nipahtv (NTV)
  • Native Kick

Please describe how you tested this change in the selected environments.

Related Issues

If this PR addresses an issue, link it here (e.g., Closes #123).

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @maksPodstawski, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug in the live video detection mechanism, specifically for the Kick platform. The change updates the logic to correctly identify live streams by checking if the video's duration is not a finite number. This ensures that videos with an infinite duration, characteristic of live content, are accurately recognized, leading to a more reliable and robust live video check.

Highlights

  • Live Video Detection Logic: The method for determining if a video is live has been updated to use "!Number.isFinite(video.duration)" instead of comparing against a fixed "KICK_LIVE_VIDEO_DURATION" constant. This improves robustness for handling live streams which often report an infinite duration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the logic for detecting live videos on Kick. The change replaces a check against a hardcoded duration value with a check for an infinite duration, which is more robust. However, the current implementation using !Number.isFinite() could incorrectly identify videos as live when their duration is NaN (e.g., before metadata has loaded). I've provided a suggestion in a review comment to make this check more precise by specifically checking for Infinity.

igorovh and others added 3 commits October 28, 2025 19:04
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@igorovh igorovh merged commit fa65139 into dev Oct 28, 2025
1 check passed
@igorovh igorovh deleted the fix/kick-latency branch October 28, 2025 18:18
igorovh added a commit that referenced this pull request Oct 28, 2025
* feat: add experimental tab (#106)

* feat: add experimental tab

* Bump vite in the npm_and_yarn group across 1 directory (#102)

Bumps the npm_and_yarn group with 1 update in the / directory: [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite).


Updates `vite` from 6.3.5 to 7.1.11
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v7.1.11/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-version: 7.1.11
  dependency-type: direct:development
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* add channel section toggle feature for Kick and Twitch platforms (#108)

* add channel section toggle feature for Kick and Twitch platforms

* Apply suggestion from @igorovh

* Apply suggestion from @igorovh

---------

Co-authored-by: igor <37638480+igorovh@users.noreply.github.com>

* fix: update live video check to handle infinite duration (#107)

* fix: update live video check to handle infinite duration

* Update src/platforms/kick/kick.utils.ts

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* remove unused var

* fixes for latency

---------

Co-authored-by: igor <37638480+igorovh@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: igorovh <xoxo@igor.ovh>

* Bump version to 5.1.17

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Maksymilian Podstawski <115575127+maksPodstawski@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants