fix: reconnecting websocket checks connection state on each request #1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clangenb
added
A1-bugfix
clangenb
force-pushed
the
cl/fix-reconnect-ws
branch
from
843bcfa
to
992a3f2
Compare
clangenb
added a commit
that referenced
this pull request
Nov 21, 2023
* [JS] remove tee proxy stuff, removes many dependencies and polyfills (#1538) * [JS] remove tee stuff, removes many dependencies and polyfills * [substrate_api] remove obsolete calls to `settings.setWorkerEndpoint` * [JS] add missing workspace dependency * Implement fixed point handling (#1543) * working wip that parses fixed point number 1. * extract `ew_substrate_fixed` package * [ew_substrate_fixed] improve code quality. * [ew_substrate_fixed] add some tests, all passing * [ew_substrate_fixed] fix handling of negative numbers and add more tests * [ew_substrate_fixed] add some more documentation * [ew_substrate_fixed] rename source file and its test to `parse_fixed_point` * [ew_substrate_fixed] add `to_fixed_point` and tests * [ew_substrate_fixed] restructure fixed point library and implement fixed arithmetics for certain types. * [ew_substrate_fixed] add note that the function does not work for negative numbers yet. * [ew_substrate_fixed] update library description * fix backslash in pubspec overrides * fmt * extend doc comment * [ew_substrate_fixed] consistent naming: fraction -> fractional * [ew_substrate_fixed] fix test naming * [ew_substrate_fixed] remove unnecessary check * [ew_substrate_fixed] add exception * [ew_substrate_fixed] fix documentation * fmt * Fix android device tests; use macos 12 runners and switch to api level 33 (#1545) * [GHA/android_integration_tests] bump setup-android to v3 * [GHA/android_integration_tests] try using api level 30 now. * [GHA/android_integration_tests] execute CI on this branch * Revert "[GHA/android_integration_tests] bump setup-android to v3" This reverts commit 2eed8b3. * [GHA/android_integration_tests] add architecture so that it finds the system image * [GHA/android_integration_tests] try API 33 * [GHA/android-integration-tests] use macos-12 again * [GHA/android-integration-tests] fix add `arch: x86_64` to the integration test execution too. * [GHA] remove workflow execution of branch and add comment * [GHA] increase timeout to 70 minutes * bump melos and always use the project's melos instead of the global one (#1548) * bump melos and simplify command * test new command in CI * new try for running melos in CI * use project melos everywhere instead of global one * [GHA] don't run unit tests on this branch anymore * [melos] simplify the rest of the commands * use exact version of melos * fix doc comment * try fix format check * fix remaining commands * fix command * fix readme * Bump flutter v3.13.8 xcode15 (#1519) * build on IOS 17 is successfully * Tested on Android * bymp flutter v3.13.8 * bum dependencies * tested on Android * tested on IOS * for test * for test * for test * for test * for test * success... * fix: Readme Xcode version * fixed by comment * Pulled origin master && Fixed all conflicts * [android] update gradle --------- Co-authored-by: clangenb <37865735+clangenb@users.noreply.github.com> * add `ew_encointer_utils` package and compute meetup time in dart (#1549) * add encointer utils package * [ew_encointer_utils] rename source file from encointer to assigment.dart * [melos] fix: execute pub get also in packages * bump test watcher dependencies to fix test execution from IDE. * [ew_encointer_utils] add `meetupTimeFunction` * [ew_encointer_utils] add fixme comment for momentsPerDay * [ew_encointer_utils] fmt * avoid using subdomains for openstreetmap server (#1551) * Fix docker and colima install in CI (#1556) * [GHA/io_integration_test] run brew update before brew install * [GHA/io_integration_test] execute CI on this branch * [GHA/io_integration_test] fix python link error. * [GHA/io_integration_test] run on all branches * Bump polkadart and create extrinsic types (#1552) * bump polkadart * fix duplicate type defs after polkadart update * [ew_polkadart] regenerate polkadart types * [melos] replace deprecated flutter run with dart run * replace encointer endpoint for type generation as onfinality had issues. * ignore linter warning for generated files. * [send_tx_dart] use polkadart's author api to send extrinsics * fix linter warning * [send_tx_dart] rename subresponse to sub * fix: reconnecting websocket checks connection state on each request (#1553) * fix: reconnecting websocket checks connection state on each request * [substrate_api] `ReconnectingWebsocketProvider` fix things for good. * [send_tx_dart] fix channel check in disconnect method * v1.11.2 --------- Co-authored-by: Eldiiar Almazbek <76556278+Eldar2021@users.noreply.github.com>
This was referenced Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1529, when we started sending txs with dart, I implemented all the fundamentals to try to reconnect upon each request if we are disconnected, but I forgot to actually call that check in the
sendandsubscriptionmethods. This should make our send process much more stable.It is difficult to say, as I don't have the exact logs, but I think it closes #1546.