Bump flutter v3.13.8 xcode15 #1519

Eldar2021 · 2023-10-18T14:28:16Z

Bump flutter 3.13.8 & Xcode 15.0, closes #1518.

Eldar2021 · 2023-10-20T20:10:49Z

I can't say anything for Android. IOS error is related to scroll. I think we're ready to review.

clangenb

Very good. Thank you so much for this maintenance effort! It looks good to me in general. I just have a few questions. :)

README.md

clangenb · 2023-10-21T11:50:08Z

app/lib/page/profile/account/account_manage_page.dart

@@ -173,7 +176,7 @@ class _AccountManagePageState extends State<AccountManagePage> {
                )
              : Text(l10n.canUseFaucetOnlyWithCurrentAccount, style: h3Grey, textAlign: TextAlign.left)
        else
-          const CupertinoActivityIndicator(),
+          appConfig.isIntegrationTest ? const SizedBox.shrink() : const CupertinoActivityIndicator(),


Can you explain this change? :)

Yes, I can explain. After changing network show Benifest progressing indicator. And I tried to fix it. However, while reading the comment, I ignored it for now only for integration testing.

encointer-wallet-flutter/app/lib/page/profile/account/account_manage_page.dart

Lines 155 to 176 in aa01557

// Not an ideal practice, but we only release a dev-version of the faucet, and cleanup can be later.

List<Widget> benefits() {

return [

Text(l10n.benefits, style: h3Grey, textAlign: TextAlign.left),

if (faucets != null)

store.account.currentAccountPubKey! == accountToBeEditedPubKey

? ListView.builder(

shrinkWrap: true,

itemCount: faucets!.length,

itemBuilder: (BuildContext context, int index) {

final faucetAccount = faucets!.keys.elementAt(index);

return FaucetListTile(

store,

userAddress: addressSS58,

faucet: faucets![faucetAccount]!,

faucetAccount: faucetAccount,

);

},

)

: Text(l10n.canUseFaucetOnlyWithCurrentAccount, style: h3Grey, textAlign: TextAlign.left)

else

const CupertinoActivityIndicator(),

app/pubspec.yaml

app/test_driver/app/account_manage/account_manage_test.dart

app/test_driver/app/login/login_test.dart

Eldar2021 · 2023-10-21T13:05:29Z

iPhone 8 error (error with scroll, driver cannot display dev scan button):
I added scroll to our test but it didn't work properly (developer mode false), it doesn't scroll and sometimes it succeeds and sometimes it fails. We will try with Patrol, if we get the same result we will look for another solution.

I can't say anything about the Android bug. It works fine on my computer.

Eldar2021 · 2023-10-21T13:12:30Z

And I have to say this.
After upgrading the flutter_map package, we get a note warning

I/flutter ( 5183): ┌───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
I/flutter ( 5183): │ ⚠️ flutter_map
I/flutter ( 5183): │ ⚠️ Avoid using subdomains with OSM's tile server. Support may be become slow or be removed in future.
I/flutter ( 5183): │ ⚠️ See https://github.com/openstreetmap/operations/issues/737 for more info.
I/flutter ( 5183): └───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────

clangenb · 2023-10-23T05:36:17Z

I can confirm that IOS successfully builds in the app store. However, Android fails currently with the below error:

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:checkPlayReleaseAarMetadata'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.CheckAarMetadataWorkAction
   > 2 issues were found when checking AAR metadata:

       1.  Dependency 'androidx.webkit:webkit:1.8.0' requires libraries and applications that
           depend on it to compile against version 34 or later of the
           Android APIs.

           :app is currently compiled against android-33.

           Also, the maximum recommended compile SDK version for Android Gradle
           plugin 7.2.1 is 32.

           Recommended action: Update this project's version of the Android Gradle
           plugin to one that supports 34, then update this project to use
           compileSdkVerion of at least 34.

           Note that updating a library or application's compileSdkVersion (which
           allows newer APIs to be used) can be done separately from updating
           targetSdkVersion (which opts the app in to new runtime behavior) and
           minSdkVersion (which determines which devices the app can be installed
           on).

       2.  Dependency 'androidx.browser:browser:1.6.0' requires libraries and applications that
           depend on it to compile against version 34 or later of the
           Android APIs.

           :app is currently compiled against android-33.

           Also, the maximum recommended compile SDK version for Android Gradle
           plugin 7.2.1 is 32.

           Recommended action: Update this project's version of the Android Gradle
           plugin to one that supports 34, then update this project to use
           compileSdkVerion of at least 34.

           Note that updating a library or application's compileSdkVersion (which
           allows newer APIs to be used) can be done separately from updating
           targetSdkVersion (which opts the app in to new runtime behavior) and
           minSdkVersion (which determines which devices the app can be installed
           on).

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

I think updating gradle could help.

…encointer/encointer-wallet-flutter into el/bump-flutter-v3.13.7-xcode15

clangenb · 2023-11-10T03:18:18Z

Updated gradle, let's hope it fixes the appcenter build 🤞

clangenb · 2023-11-10T04:02:15Z

Build worked now in appcenter! 🥳

# Conflicts: # pubspec.lock # pubspec.yaml # scripts/install_melos.sh

* [JS] remove tee proxy stuff, removes many dependencies and polyfills (#1538) * [JS] remove tee stuff, removes many dependencies and polyfills * [substrate_api] remove obsolete calls to `settings.setWorkerEndpoint` * [JS] add missing workspace dependency * Implement fixed point handling (#1543) * working wip that parses fixed point number 1. * extract `ew_substrate_fixed` package * [ew_substrate_fixed] improve code quality. * [ew_substrate_fixed] add some tests, all passing * [ew_substrate_fixed] fix handling of negative numbers and add more tests * [ew_substrate_fixed] add some more documentation * [ew_substrate_fixed] rename source file and its test to `parse_fixed_point` * [ew_substrate_fixed] add `to_fixed_point` and tests * [ew_substrate_fixed] restructure fixed point library and implement fixed arithmetics for certain types. * [ew_substrate_fixed] add note that the function does not work for negative numbers yet. * [ew_substrate_fixed] update library description * fix backslash in pubspec overrides * fmt * extend doc comment * [ew_substrate_fixed] consistent naming: fraction -> fractional * [ew_substrate_fixed] fix test naming * [ew_substrate_fixed] remove unnecessary check * [ew_substrate_fixed] add exception * [ew_substrate_fixed] fix documentation * fmt * Fix android device tests; use macos 12 runners and switch to api level 33 (#1545) * [GHA/android_integration_tests] bump setup-android to v3 * [GHA/android_integration_tests] try using api level 30 now. * [GHA/android_integration_tests] execute CI on this branch * Revert "[GHA/android_integration_tests] bump setup-android to v3" This reverts commit 2eed8b3. * [GHA/android_integration_tests] add architecture so that it finds the system image * [GHA/android_integration_tests] try API 33 * [GHA/android-integration-tests] use macos-12 again * [GHA/android-integration-tests] fix add `arch: x86_64` to the integration test execution too. * [GHA] remove workflow execution of branch and add comment * [GHA] increase timeout to 70 minutes * bump melos and always use the project's melos instead of the global one (#1548) * bump melos and simplify command * test new command in CI * new try for running melos in CI * use project melos everywhere instead of global one * [GHA] don't run unit tests on this branch anymore * [melos] simplify the rest of the commands * use exact version of melos * fix doc comment * try fix format check * fix remaining commands * fix command * fix readme * Bump flutter v3.13.8 xcode15 (#1519) * build on IOS 17 is successfully * Tested on Android * bymp flutter v3.13.8 * bum dependencies * tested on Android * tested on IOS * for test * for test * for test * for test * for test * success... * fix: Readme Xcode version * fixed by comment * Pulled origin master && Fixed all conflicts * [android] update gradle --------- Co-authored-by: clangenb <37865735+clangenb@users.noreply.github.com> * add `ew_encointer_utils` package and compute meetup time in dart (#1549) * add encointer utils package * [ew_encointer_utils] rename source file from encointer to assigment.dart * [melos] fix: execute pub get also in packages * bump test watcher dependencies to fix test execution from IDE. * [ew_encointer_utils] add `meetupTimeFunction` * [ew_encointer_utils] add fixme comment for momentsPerDay * [ew_encointer_utils] fmt * avoid using subdomains for openstreetmap server (#1551) * Fix docker and colima install in CI (#1556) * [GHA/io_integration_test] run brew update before brew install * [GHA/io_integration_test] execute CI on this branch * [GHA/io_integration_test] fix python link error. * [GHA/io_integration_test] run on all branches * Bump polkadart and create extrinsic types (#1552) * bump polkadart * fix duplicate type defs after polkadart update * [ew_polkadart] regenerate polkadart types * [melos] replace deprecated flutter run with dart run * replace encointer endpoint for type generation as onfinality had issues. * ignore linter warning for generated files. * [send_tx_dart] use polkadart's author api to send extrinsics * fix linter warning * [send_tx_dart] rename subresponse to sub * fix: reconnecting websocket checks connection state on each request (#1553) * fix: reconnecting websocket checks connection state on each request * [substrate_api] `ReconnectingWebsocketProvider` fix things for good. * [send_tx_dart] fix channel check in disconnect method * v1.11.2 --------- Co-authored-by: Eldiiar Almazbek <76556278+Eldar2021@users.noreply.github.com>

Eldar2021 added 2 commits October 17, 2023 22:47

build on IOS 17 is successfully

8bdbb42

Tested on Android

15ede28

Eldar2021 added A2-technical PR introduces technical changes B0-low Does not elevate a release containing this beyond "low priority" C0-breaksnothing PR does not introduce any breaking changes labels Oct 18, 2023

Eldar2021 added 10 commits October 19, 2023 20:05

bymp flutter v3.13.8

3f19d1e

bum dependencies

03f0457

tested on Android

d4d79ac

tested on IOS

23cfddb

for test

336b2f7

for test

08a9726

for test

62aba94

for test

efa5658

for test

8e6e958

success...

00b44aa

Eldar2021 marked this pull request as ready for review October 20, 2023 17:11

Eldar2021 requested a review from clangenb October 20, 2023 17:11

Eldar2021 changed the title ~~Bump flutter v3.13.7 xcode15~~ Bump flutter v3.13.8 xcode15 Oct 20, 2023

This was linked to issues Oct 20, 2023

Bump Flutter v3.13.7 && Xcode 15 #1518

Closed

Upgrade flutter_inappwebview 6.0.0-beta.24+1 #1461

Closed

clangenb reviewed Oct 21, 2023

View reviewed changes

Eldar2021 added 2 commits October 21, 2023 18:26

fix: Readme Xcode version

a8cd17a

fixed by comment

0566b88

Eldar2021 and others added 2 commits October 22, 2023 15:13

Merge branch 'master' into el/bump-flutter-v3.13.7-xcode15

89f6a05

Merge branch 'master' into el/bump-flutter-v3.13.7-xcode15

6b1042e

clangenb mentioned this pull request Oct 22, 2023

patch bump flutter: v3.13.6 #1503

Closed

Eldar2021 and others added 5 commits November 4, 2023 20:17

pulled origin master

6881182

Pulled origin master && Fixed all conflicts

0c3a427

Merge branch 'el/bump-flutter-v3.13.7-xcode15' of https://github.com/…

6965d43

…encointer/encointer-wallet-flutter into el/bump-flutter-v3.13.7-xcode15

[android] update gradle

7a9bece

Merge branch 'master' into el/bump-flutter-v3.13.7-xcode15

920e007

clangenb approved these changes Nov 10, 2023

View reviewed changes

Merge branch 'master' into el/bump-flutter-v3.13.7-xcode15

e8d6a93

# Conflicts: # pubspec.lock # pubspec.yaml # scripts/install_melos.sh

clangenb merged commit 9b525fe into master Nov 11, 2023
16 of 17 checks passed

clangenb deleted the el/bump-flutter-v3.13.7-xcode15 branch November 11, 2023 10:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump flutter v3.13.8 xcode15 #1519

Bump flutter v3.13.8 xcode15 #1519

Eldar2021 commented Oct 18, 2023 •

edited by clangenb

Loading

Eldar2021 commented Oct 20, 2023

clangenb left a comment

clangenb Oct 21, 2023

Eldar2021 Oct 21, 2023

Eldar2021 commented Oct 21, 2023

Eldar2021 commented Oct 21, 2023

clangenb commented Oct 23, 2023

clangenb commented Nov 10, 2023

clangenb commented Nov 10, 2023

	// Not an ideal practice, but we only release a dev-version of the faucet, and cleanup can be later.
	List<Widget> benefits() {
	return [
	Text(l10n.benefits, style: h3Grey, textAlign: TextAlign.left),
	if (faucets != null)
	store.account.currentAccountPubKey! == accountToBeEditedPubKey
	? ListView.builder(
	shrinkWrap: true,
	itemCount: faucets!.length,
	itemBuilder: (BuildContext context, int index) {
	final faucetAccount = faucets!.keys.elementAt(index);
	return FaucetListTile(
	store,
	userAddress: addressSS58,
	faucet: faucets![faucetAccount]!,
	faucetAccount: faucetAccount,
	);
	},
	)
	: Text(l10n.canUseFaucetOnlyWithCurrentAccount, style: h3Grey, textAlign: TextAlign.left)
	else
	const CupertinoActivityIndicator(),

Bump flutter v3.13.8 xcode15 #1519

Bump flutter v3.13.8 xcode15 #1519

Conversation

Eldar2021 commented Oct 18, 2023 • edited by clangenb Loading

Eldar2021 commented Oct 20, 2023

clangenb left a comment

Choose a reason for hiding this comment

clangenb Oct 21, 2023

Choose a reason for hiding this comment

Eldar2021 Oct 21, 2023

Choose a reason for hiding this comment

Eldar2021 commented Oct 21, 2023

Eldar2021 commented Oct 21, 2023

clangenb commented Oct 23, 2023

clangenb commented Nov 10, 2023

clangenb commented Nov 10, 2023

Eldar2021 commented Oct 18, 2023 •

edited by clangenb

Loading