Fix Ninja support #24584
Fix Ninja support #24584
Conversation
Fixes emscripten-core#24393 by using subprocess.list2cmdline instead of shlex.join. Unfortunately, subprocess.list2cmdline is undocumented but apparently has been available for well over a decade (eg see https://stackoverflow.com/questions/12130163/how-to-get-resulting-subprocess-command-string) and, judging by discussions like https://discuss.python.org/t/why-is-subprocess-list2cmdline-not-documented/25044 is unlikely to be ever removed since it's been long used in the wild. It does exactly what we want - quote & join a command by Windows rules.
| @@ -183,13 +184,15 @@ def create_ninja_file(input_files, filename, libname, cflags, asflags=None, cust | |||
| if asflags is None: | |||
| asflags = [] | |||
|
|
|||
| join_cmd = shlex.join if os.name == 'posix' else subprocess.list2cmdline | |||
There was a problem hiding this comment.
Can we just use subprocess.list2cmdline in all cases?
There was a problem hiding this comment.
Oh I see its a windows-specific function. I guess this will have to do
There was a problem hiding this comment.
Maybe we should re-add shlex_join to utils.py and use that instead of shlex.join everywhere. Effectivly reverting #24111 but with a cleaner shlex_join impl?
There was a problem hiding this comment.
Maybe, but not sure.
As I said in #24393 (comment), it does look like all other usages are for debug purposes only so syntax doesn't matter as much, and for command invocations we normally use subprocess module which does the right thing via native APIs automatically, so Ninja usecase - where we have to stringify a command with a valid OS-specific syntax - seems somewhat special in that regard.
If nothing else pops up, I wouldn't bother generalising it for now.
Fixes #24393 by using subprocess.list2cmdline instead of shlex.join.
Unfortunately, subprocess.list2cmdline is undocumented but apparently has been available for well over a decade (eg see https://stackoverflow.com/questions/12130163/how-to-get-resulting-subprocess-command-string) and, judging by discussions like https://discuss.python.org/t/why-is-subprocess-list2cmdline-not-documented/25044 is unlikely to be ever removed since it's been long used in the wild.
It does exactly what we want - quote & join a command by Windows rules.