Use shlex.join. NFC
#24111
Merged
Use shlex.join. NFC
#24111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Apr 15, 2025
test/common.py
Outdated
| @@ -1400,7 +1400,7 @@ def build(self, filename, libraries=None, includes=None, force_c=False, emcc_arg | |||
| output = output_basename + output_suffix | |||
| else: | |||
| output = shared.unsuffixed_basename(filename) + output_suffix | |||
| cmd = compiler + [filename, '-o', output] + self.get_emcc_args(main_file=True) | |||
| cmd = compiler + [str(filename), '-o', output] + self.get_emcc_args(main_file=True) | |||
There was a problem hiding this comment.
The official shlex.join only accepts strings and not Path objects. Our version had the call to os.fspath in it.
kripken
approved these changes
Apr 15, 2025
We bumped the minimum python version to 3.8 in emscripten-core#23417. I guess I overlooked this change at the time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We bumped the minimum python version to 3.8 in #23417. I guess I overlooked this change at the time.