Fix sysroot installation when emscripten itself is read-only #24405
+45
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like constructing a test for this would be tricky... do you think we can land this without a test? I verified it works locally with a read-only root-owned copy of emscripten. |
sbc100
force-pushed
the
fix_readonly_install
branch
from
c12678b to
b5c4961
Compare
sbc100
force-pushed
the
fix_readonly_install
branch
from
b5c4961 to
678fcfe
Compare
|
I guess we need to add tests since this already regressed once. |
|
I confirmed on my machine that this patch fixes the original issue I encountered. |
sbc100
force-pushed
the
fix_readonly_install
branch
from
678fcfe to
2f87928
Compare
|
I found a way to test this. Confirmed that the test fails without this change. |
The resulting header tree need to be at least user-writable so that we can incrementally copy files into it, adding new files and also updating previously copied ones. Sadly, python's shutil doesn't seem to have any options for disabling the copying of mode bits. This was originally fixed in emscripten-core#15386 but then regressed in emscripten-core#23417. Fixes: emscripten-core#24404
sbc100
force-pushed
the
fix_readonly_install
branch
from
2f87928 to
f4d358d
Compare
kripken
approved these changes
May 23, 2025
|
@sbc100 Thank you for the prompt fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resulting header tree need to be at least user-writable so that we can incrementally copy files into it, adding new files and also updating previously copied ones.
Sadly, python's shutil doesn't seem to have any options for disabling the copying of mode bits.
This was originally fixed in #15386 but then regressed in #23417.
Fixes: #24404