Always copy files as writable #15386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `chmod` to ensure that any copied files are writable. I tried using `copyfile` which avoids copying permissions altogether by we have some files (e.g. `sdl2-config`) which are executable so we need to preserve at least some permissions. This can be importantant in `install_system_headers` which copies files from the emscripten directory (which may be read only) in the cache directory. In this case we don't want the resulting files in the cache to also be read only. Fixes: #15374
|
Split out from the larger attempt: #15384 |
kripken
approved these changes
Oct 28, 2021
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 23, 2025
The resulting header tree need to be at least user-writable so that we can incrementally copy files into it, adding new files and also updating previously copied ones. Sadly, python's shutil doesn't seem to have any options for disabling the copying of mode bits. This was originally fixed in emscripten-core#15386 but then regressed in emscripten-core#23417. Fixes: emscripten-core#24404
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 23, 2025
The resulting header tree need to be at least user-writable so that we can incrementally copy files into it, adding new files and also updating previously copied ones. Sadly, python's shutil doesn't seem to have any options for disabling the copying of mode bits. This was originally fixed in emscripten-core#15386 but then regressed in emscripten-core#23417. Fixes: emscripten-core#24404
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 23, 2025
The resulting header tree need to be at least user-writable so that we can incrementally copy files into it, adding new files and also updating previously copied ones. Sadly, python's shutil doesn't seem to have any options for disabling the copying of mode bits. This was originally fixed in emscripten-core#15386 but then regressed in emscripten-core#23417. Fixes: emscripten-core#24404
sbc100
added a commit
that referenced
this pull request
May 23, 2025
The resulting header tree need to be at least user-writable so that we can incrementally copy files into it, adding new files and also updating previously copied ones. Sadly, python's shutil doesn't seem to have any options for disabling the copying of mode bits. This was originally fixed in #15386 but then regressed in #23417. Fixes: #24404
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
chmodto ensure that any copied files are writable. I tried usingcopyfilewhich avoids copying permissions altogether by we have somefiles (e.g.
sdl2-config) which are executable so we need to preserveat least some permissions.
This can be importantant in
install_system_headerswhich copies filesfrom the emscripten directory (which may be read only) in the cache
directory. In this case we don't want the resulting files in the cache
to also be read only.
Fixes: #15374