Disable tests to let binaryen#6793 roll in #22308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
approved these changes
Aug 1, 2024
Collaborator
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
(You can use @disabled(...) instead of self.skipTest.. not that it really matters)
Member
Author
Ah, thanks, I'll do that next time (to avoid re-running tests here). |
kripken
added a commit
that referenced
this pull request
Aug 2, 2024
This re-enables the tests and updates the outputs. The suffixes vanish here as WebAssembly/binaryen#6793 replaces .1 with _1, and we have code in this test to ignore such suffixes (as LLVM adds them, and we strip hem to make the output less likely to change frequently).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebAssembly/binaryen#6793 alters names of functions, which two metadce
tests turn out to be sensitive to. (It changes the suffixes we use to deduplicate
identical names.)