Skip to content

Commit 5912f8d

Browse files
authored
Disable tests to let binaryen#6793 roll in (#22308)
WebAssembly/binaryen#6793 alters names of functions, which two metadce tests turn out to be sensitive to. (It changes the suffixes we use to deduplicate identical names.)
1 parent 9b99b5d commit 5912f8d

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

test/test_other.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8667,6 +8667,8 @@ def test_metadce_minimal(self, *args):
86678667

86688668
@node_pthreads
86698669
def test_metadce_minimal_pthreads(self):
8670+
self.skipTest('let https://github.com/WebAssembly/binaryen/pull/6793 roll')
8671+
86708672
self.run_metadce_test('minimal_main.c', ['-Oz', '-pthread', '-sPROXY_TO_PTHREAD'])
86718673

86728674
@parameterized({
@@ -8747,7 +8749,9 @@ def test_metadce_libcxxabi_message(self, *args):
87478749

87488750
@parameterized({
87498751
'js_fs': (['-O3', '-sNO_WASMFS'], [], []), # noqa
8750-
'wasmfs': (['-O3', '-sWASMFS'], [], []), # noqa
8752+
# TODO: Re-enable after https://github.com/WebAssembly/binaryen/pull/6793
8753+
# rolls in.
8754+
# 'wasmfs': (['-O3', '-sWASMFS'], [], []), # noqa
87518755
})
87528756
def test_metadce_files(self, *args):
87538757
self.run_metadce_test('files.cpp', *args)

0 commit comments

Comments
 (0)