DOCS Update Module-Splitting code #20118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few fixes to the module splitting code example: 1. I'm not sure when `wasmExports` exists, but when I tried this, I had to use `Module.asm` instead. 2. Using `buffer` yields an error saying it's been removed and to use `HEAP8.buffer` instead. 3. `nodeFS` is not defined unless we specifically `require` it.
Collaborator
Member
|
Oh, I guess @sbc100's comment means the change to |
Collaborator
Author
|
I restored |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few fixes to the module splitting code example:
wasmExportsexists, but when I tried this, I had to useModule.asminstead.bufferyields an error saying it's been removed and to useHEAP8.bufferinstead.nodeFSis not defined unless we specificallyrequireit.