Continue transition from asm to wasmExports. NFC
#19900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
wasmExports_part2
branch
from
ce521e0 to
d54e9d9
Compare
sbc100
force-pushed
the
wasmExports_part2
branch
from
d54e9d9 to
140c53e
Compare
I missed a few cases back in #19816. This change completely the transition saving even more on code size.
sbc100
force-pushed
the
wasmExports_part2
branch
from
140c53e to
829e61e
Compare
kripken
reviewed
Jul 26, 2023
| @@ -53,7 +53,6 @@ if (typeof WebAssembly != 'object') { | |||
| // Wasm globals | |||
|
|
|||
| var wasmMemory; | |||
| var wasmExports; | |||
There was a problem hiding this comment.
Where is this defined if not here?
There was a problem hiding this comment.
emscripten.py declares this, on line 818
There was a problem hiding this comment.
Ah, I missed that somehow, thanks.
kripken
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed a few cases back in #19816. This change completely the transition saving even more on code size.