Skip to content

Check return codes in mp_run_process #17882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Check return codes in mp_run_process #17882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions tools/shared.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,15 +116,19 @@ def get_num_cores():


def mp_run_process(command_tuple):
temp_files = get_temp_files()
cmd, env, route_stdout_to_temp_files_suffix, pipe_stdout, check, cwd = command_tuple
std_out = temp_files.get(route_stdout_to_temp_files_suffix) if route_stdout_to_temp_files_suffix else (subprocess.PIPE if pipe_stdout else None)
ret = std_out.name if route_stdout_to_temp_files_suffix else None
proc = subprocess.Popen(cmd, stdout=std_out, stderr=subprocess.PIPE if pipe_stdout else None, env=env, cwd=cwd)
out, _ = proc.communicate()
if pipe_stdout:
ret = out.decode('UTF-8')
return ret
stdout = None
stderr = None
if route_stdout_to_temp_files_suffix:
stdout = get_temp_files().get(route_stdout_to_temp_files_suffix)
elif pipe_stdout:
stdout = subprocess.PIPE
stderr = subprocess.PIPE
proc = subprocess.run(cmd, stdout=stdout, stderr=stderr, env=env, cwd=cwd, check=True)
if route_stdout_to_temp_files_suffix:
return stdout.name
elif pipe_stdout:
return proc.stdout.decode('UTF-8')


def returncode_to_str(code):
Expand Down