Check return codes in mp_run_process
#17882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
fix_mulitple_subprocesses
branch
from
ae15c78 to
93de0d1
Compare
This codepath is not normally used since once currently needs to opt into using via EM_PYTHON_MULTIPROCESSING=1. However, I'm hoping to remove that limitation in #17881. This cleaanup/fix should land before #17881 does. The primary change here is to switch from `subprocessrun.Popen` to `subprocess.run` which supports the `check=True` argument. As well as avoiding the need for the call to `communicate()`
sbc100
force-pushed
the
fix_mulitple_subprocesses
branch
from
93de0d1 to
4e88460
Compare
kripken
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This codepath is not normally used since once currently needs to opt into using via EM_PYTHON_MULTIPROCESSING=1.
However, I'm hoping to remove that limitation in #17881. This cleaanup/fix should land before #17881 does.
The primary change here is to switch from
subprocessrun.Popentosubprocess.runwhich supports thecheck=Trueargument. As well as avoiding the need for the call tocommunicate()