Avoid keeping module file open in tools/webassembly.py API #17271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will land TBR to fix the emscripten roller (assuming tests pass) |
These was a bug in my imlemenation of `@cache` that I added in #17255 where it was keeping the underlying wasm file open and never actually closing it. This is because I was using the incoming arguments as the hash key instead of their hash value. The bug only manifested on windows where open files are locked in some way prevented futher actions from modifying them and resulting is a strange error: ```llvm-objcopy.exe: error: permission denied```
sbc100
force-pushed
the
fix_webassembly_windows
branch
from
c3a8f37 to
524108e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These was a bug in my imlemenation of
@cachethat I added in #17255where it was keeping the underlying wasm file open and never actually
closing it. This is because I was using the incoming arguments as the
hash key instead of their hash value.
The bug only manifested on windows where open files are locked in some
way prevented futher actions from modifying them and resulting is a
strange error:
llvm-objcopy.exe: error: permission denied