Simplify extract_metadata.py by moving logic in tools/webassembly.py. NFC #17255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
commented
Jun 17, 2022
tools/webassembly.py
Outdated
|
|
||
| def parse_dylink_section(self): | ||
| if self._have_cached_section_info('dylink'): | ||
| return self._get_cached_section_info('dylink') |
There was a problem hiding this comment.
I should probably turn this into a decorator... but maybe as a followup.
There was a problem hiding this comment.
Oh wait.. I can just use @functools memoization instead of all this.
sbc100
force-pushed
the
webassembly_python_cleanup
branch
from
77761f3 to
9f84e85
Compare
dschuff
reviewed
Jun 17, 2022
tools/webassembly.py
Outdated
| def has_name_section(self): | ||
| return self.get_custom_section('name') is not None | ||
|
|
||
| _done_read_imports = False |
There was a problem hiding this comment.
can this just be turned into @cache too?
There was a problem hiding this comment.
Its seems like a slightly different use case.. since it doesn't return anything. But in theory yes I think so..
There was a problem hiding this comment.
Ah, right, it would be a bit weird. Well, either way is fine; I just noticed that it was asymmetric.
sbc100
force-pushed
the
webassembly_python_cleanup
branch
from
9f84e85 to
0a23342
Compare
dschuff
approved these changes
Jun 17, 2022
tools/webassembly.py
Outdated
| def has_name_section(self): | ||
| return self.get_custom_section('name') is not None | ||
|
|
||
| _done_read_imports = False |
There was a problem hiding this comment.
Ah, right, it would be a bit weird. Well, either way is fine; I just noticed that it was asymmetric.
sbc100
force-pushed
the
webassembly_python_cleanup
branch
from
0a23342 to
9d48fd8
Compare
|
Seems that |
dschuff
reviewed
Jun 17, 2022
| return leb128.i.decode_reader(iobuf)[0] | ||
|
|
||
|
|
||
| # TODO(sbc): Use the builtin functools.cache once we update to python 3.9 |
|
LGTM |
sbc100
force-pushed
the
webassembly_python_cleanup
branch
from
9d48fd8 to
6cc9ad1
Compare
sbc100
force-pushed
the
webassembly_python_cleanup
branch
from
6cc9ad1 to
77dea47
Compare
kripken
approved these changes
Jun 17, 2022
… NFC This creates a caching layer and some extra helper functions on the module object which avoid the need to track start such as the number of imports elements of a given type.
sbc100
force-pushed
the
webassembly_python_cleanup
branch
from
77dea47 to
af7703a
Compare
sbc100
added a commit
that referenced
this pull request
Jun 19, 2022
These was a bug in my imlemenation of `@cache` that I added in #17255 where it was keeping the underlying wasm file open and never actually closing it. This is because I was using the incoming arguments as the hash key instead of their hash value. The bug only manifested on windows where open files are locked in some way prevented futher actions from modifying them and resulting is a strange error: ```llvm-objcopy.exe: error: permission denied```
sbc100
added a commit
that referenced
this pull request
Jun 19, 2022
These was a bug in my imlemenation of `@cache` that I added in #17255 where it was keeping the underlying wasm file open and never actually closing it. This is because I was using the incoming arguments as the hash key instead of their hash value. The bug only manifested on windows where open files are locked in some way prevented futher actions from modifying them and resulting is a strange error: ```llvm-objcopy.exe: error: permission denied```
sbc100
added a commit
that referenced
this pull request
Jun 19, 2022
These was a bug in my implementation of `@cache` that I added in #17255 where it was keeping the underlying wasm file open and never actually closing it. This is because I was using the incoming arguments as the hash key instead of their hash value. The bug only manifested on windows where open files are locked in some way prevented further actions from modifying them and resulting is a strange error: ```llvm-objcopy.exe: error: permission denied```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a caching layer and some extra helper functions on the
module object which avoid the need to track start such as the number
of imports elements of a given type.