file_packager.py: Round two of cleanups and refactorings. NFC #16049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
cleanup_file_packager2
branch
from
92608cb to
fc89621
Compare
sbc100
changed the title
sbc100
force-pushed
the
cleanup_file_packager2
branch
from
fc89621 to
decb32d
Compare
sbc100
force-pushed
the
file_packager_options
branch
from
1e92e6c to
403737b
Compare
sbc100
force-pushed
the
cleanup_file_packager2
branch
from
decb32d to
52ff804
Compare
The biggest change here is the of a DataFile class over raw dict. This simplifies field access and makes things more explicit. I tried to use `namedtuple` here but we need to write to at least one of the fields.
sbc100
force-pushed
the
cleanup_file_packager2
branch
from
52ff804 to
3dbf141
Compare
|
Last round of cleanups to prepare for #16050 |
kripken
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biggest change here is the of a DataFile class over raw dict.
This simplifies field access and makes things more explicit. I
tried to use
namedtuplehere but we need to write to at leastone of the fields.