file_packager.py: Add option to embed file data in wasm binary #16050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
cleanup_file_packager2
branch
from
92608cb to
fc89621
Compare
sbc100
force-pushed
the
file_packager_native
branch
from
c4718b7 to
eadafba
Compare
|
This change depends of a chain of cleanup/refactoring PRs than need to land first: |
sbc100
force-pushed
the
cleanup_file_packager2
branch
from
fc89621 to
decb32d
Compare
sbc100
force-pushed
the
file_packager_native
branch
3 times, most recently
from
002aa28 to
9258fe2
Compare
sbc100
force-pushed
the
file_packager_native
branch
from
9258fe2 to
da737b9
Compare
|
Also depends on this llvm change: https://reviews.llvm.org/D117412 |
sbc100
force-pushed
the
cleanup_file_packager2
branch
2 times, most recently
from
52ff804 to
3dbf141
Compare
sbc100
force-pushed
the
file_packager_native
branch
from
da737b9 to
d33e5dd
Compare
sbc100
force-pushed
the
file_packager_native
branch
from
d33e5dd to
2bc217b
Compare
This was referenced Jan 19, 2022
kripken
approved these changes
Jan 19, 2022
|
Perhaps mention the changelog? |
sbc100
force-pushed
the
file_packager_native
branch
2 times, most recently
from
c3da14e to
2ecbd15
Compare
I think it should "just work" .. all it depends on is the |
sbc100
force-pushed
the
file_packager_native
branch
from
2ecbd15 to
93a23d6
Compare
This change not only adds the new option but uses this option whenever file_packager is used from within emcc. Hopefully we can find a way deprecate and remove the old JS embedded since that seems strictly worse in almost ever way. - Larger code size (JS base64 encoding is larger than binary) - No possiblity of zero copy, memory-backed files - Less compatible with standalone wasm / WASI
sbc100
force-pushed
the
file_packager_native
branch
from
93a23d6 to
adbf8dd
Compare
|
This seems to have broken the roller on windows: |
sbc100
added a commit
that referenced
this pull request
Jan 23, 2022
sbc100
added a commit
that referenced
this pull request
Jan 23, 2022
sbc100
added a commit
that referenced
this pull request
Jan 23, 2022
sbc100
added a commit
that referenced
this pull request
Jan 23, 2022
sbc100
added a commit
that referenced
this pull request
Jan 23, 2022
kripken
added a commit
that referenced
this pull request
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change not only adds the new option but uses this option
whenever
file_packageris called from within emcc.Very heavily inspired by the larger change in #16028.
Hopefully we can find a way deprecate and remove the old JS
embedding code since that seems strictly worse in every(?) way: