Skip to content

Re-enable test_split_main_module. NFC #13849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2021
Merged

Re-enable test_split_main_module. NFC #13849

merged 1 commit into from
Apr 9, 2021

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Apr 8, 2021 •
edited
Loading

Somehow this was magically fixed

Closes: WebAssembly/binaryen#3701

@sbc100
Re-enable test_split_main_module. NFC
58d2d53 
Something this was magically fixed

Closes: WebAssembly/binaryen#3701
@sbc100 sbc100 enabled auto-merge (squash) April 8, 2021 21:53
@sbc100 sbc100 requested a review from tlively April 9, 2021 00:24
tlively
tlively approved these changes Apr 9, 2021
View reviewed changes
Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, I wonder if switching to the new pass manager and its more aggressive inliner reduced the required table size again.

@sbc100 sbc100 merged commit 0bafd1c into main Apr 9, 2021
@sbc100 sbc100 deleted the reenable_test branch April 9, 2021 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlively tlively tlively approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wasm-split producing invalid modules
2 participants
@sbc100 @tlively