Refactor Ports.fetch_port to avoid locking the cache where possible #13321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in service of improving support for FROZEN_CACHE and is needed as part of #13316. The logic here mirrors the lock in cache.get() where we first attempt to verify the contents of the cache without holding the lock and early out in the common case the what we want is already here.
sbc100
force-pushed
the
avoid_cache_lock_ports
branch
from
c386b6c to
8905799
Compare
kripken
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in service of improving support for FROZEN_CACHE and is needed
as part of #13316.
The logic here mirrors the lock in cache.get() where we first attempt to
verify the contents of the cache without holding the lock and early out
in the common case the what we want is already here.