Avoid writing even sanity.txt if FROZEN_CACHE is enabled #13316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
improve_froze_cache
branch
4 times, most recently
from
211b7f7 to
cde0c76
Compare
sbc100
added a commit
that referenced
this pull request
Jan 26, 2021
This is in service of improving support for FROZEN_CACHE and is needed as part of #13316. The logic here mirrors the lock in cache.get() where we first attempt to verify the contents of the cache without holding the lock and early out in the common case the what we want is already here.
sbc100
added a commit
that referenced
this pull request
Jan 26, 2021
This is in service of improving support for FROZEN_CACHE and is needed as part of #13316. The logic here mirrors the lock in cache.get() where we first attempt to verify the contents of the cache without holding the lock and early out in the common case the what we want is already here.
sbc100
force-pushed
the
improve_froze_cache
branch
3 times, most recently
from
85990b9 to
f795dfe
Compare
sbc100
force-pushed
the
improve_froze_cache
branch
from
f795dfe to
372386b
Compare
sbc100
force-pushed
the
avoid_cache_lock
branch
from
8c3d63e to
514871d
Compare
sbc100
force-pushed
the
improve_froze_cache
branch
2 times, most recently
from
ad94a68 to
4c1b540
Compare
sbc100
force-pushed
the
avoid_cache_lock
branch
from
514871d to
ffa824a
Compare
These improvements to the FROZE_CACHE setting allow for a pre-populated read-only cache. In thie senario the cache is cannot ever be locked, and that we don't even write the sanity file. Users can still forece a sanity check with `emcc --check` but no sanity file will ever be written.
sbc100
force-pushed
the
improve_froze_cache
branch
from
4c1b540 to
0f46f59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These improvements to the FROZE_CACHE setting allow for a
pre-populated read-only cache. In thie senario the cache
is cannot ever be locked, and that we don't even write
the sanity file.
Users can still forece a sanity check with
emcc --checkbut no sanity file will ever be written.