Skip to content

Add libgif port #13139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 13, 2021
Merged

Add libgif port #13139

merged 7 commits into from
Jan 13, 2021

Conversation

saschanaz
Copy link
Collaborator

This can successfully build JPEG XL reference software with GIF support.

saschanaz added a commit to saschanaz/jxl-wasm that referenced this pull request Dec 30, 2020
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the relationship between JPEG XL and libgif? (Sorry, I don't know much about this area - when I did a search for libgif I found "giflib" which doesn't mention JPEG XL at all, is that something else?)

@saschanaz
Copy link
Collaborator Author

giflib is libgif as zlib is libz. Maybe it should be giflib here to follow zlib.

@saschanaz
Copy link
Collaborator Author

What is the relationship between JPEG XL and libgif

https://gitlab.com/wg1/jpeg-xl depends on giflib to decode gif. I just intended to say I tested this with a real world project.

@saschanaz saschanaz force-pushed the libgif branch 2 times, most recently from d3f17cd to c11f202 Compare January 8, 2021 00:46
@kripken
Copy link
Member

kripken commented Jan 12, 2021

I see, thanks @saschanaz !

Ok, looks good, just please add a test before we land. Can be similar to the test for libjpeg for example,

emscripten/tests/test_other.py

Lines 1501 to 1506 in 63422ac

def test_libjpeg(self):
shutil.copyfile(path_from_root('tests', 'screenshot.jpg'), 'screenshot.jpg')
building.emcc(path_from_root('tests', 'jpeg_test.c'), ['--embed-file', 'screenshot.jpg', '-s', 'USE_LIBJPEG'], output_filename='a.out.js')
self.assertContained('Image is 600 by 450 with 3 components', self.run_js('a.out.js', args=['screenshot.jpg']))

@kripken kripken merged commit 97f13a1 into master Jan 13, 2021
@kripken kripken deleted the libgif branch January 13, 2021 22:56
kripken pushed a commit that referenced this pull request Jan 25, 2021
#13209 added get_lib but it was missed in #13139.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants