-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add libgif port #13139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libgif port #13139
Conversation
This depends on emscripten-core/emscripten#13139. Closes #2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the relationship between JPEG XL and libgif? (Sorry, I don't know much about this area - when I did a search for libgif I found "giflib" which doesn't mention JPEG XL at all, is that something else?)
giflib is libgif as zlib is libz. Maybe it should be giflib here to follow zlib. |
https://gitlab.com/wg1/jpeg-xl depends on giflib to decode gif. I just intended to say I tested this with a real world project. |
d3f17cd
to
c11f202
Compare
I see, thanks @saschanaz ! Ok, looks good, just please add a test before we land. Can be similar to the test for libjpeg for example, emscripten/tests/test_other.py Lines 1501 to 1506 in 63422ac
|
This can successfully build JPEG XL reference software with GIF support.