Use single cache rather then reconfiguring/moving it #13209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
use_single_cache
branch
from
dc84cef to
72d6be9
Compare
kripken
approved these changes
Jan 8, 2021
tools/cache.py
Outdated
|
|
||
| def erase_file(self, shortname): | ||
| name = os.path.join(self.dirname, shortname) | ||
| if os.path.exists(name): | ||
| logging.info('Cache: deleting cached file: %s', name) | ||
| tempfiles.try_delete(name) | ||
|
|
||
| def getlib(self, libname, *args, **kwargs): |
sbc100
force-pushed
the
use_single_cache
branch
2 times, most recently
from
eb0043a to
1b4fa88
Compare
This was split out from the change to use a single sysroot (#13090). I think it cleaner this way: There is single cache, with single lock file and the root doesn't change, but the libraries live in sub-directories within the cache.
sbc100
force-pushed
the
use_single_cache
branch
from
1b4fa88 to
bfec96b
Compare
kripken
pushed a commit
that referenced
this pull request
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was split out from the change to use a single sysroot (#13090). I
think it cleaner this way: There is single cache, with single lock file
and the root doesn't change, but the libraries live in sub-directories
within the cache.