forked from OpenAPITools/openapi-generator
-
Notifications
You must be signed in to change notification settings - Fork 1
[Rust] Use query and form features from reqwest-middleware #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adi-code
wants to merge
123
commits into
emilbonnek:master
Choose a base branch
from
adi-code:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [qs](https://github.com/ljharb/qs) from 6.13.0 to 6.14.1. - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md) - [Commits](ljharb/qs@v6.13.0...v6.14.1) --- updated-dependencies: - dependency-name: qs dependency-version: 6.14.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [swift][client] Remove old objc samples * [swift][client] Update CI to use Xcode 26 * Revert "[swift][client] Remove old objc samples" This reverts commit b501899.
…22668) Bumps [qs](https://github.com/ljharb/qs) from 6.14.0 to 6.14.1. - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md) - [Commits](ljharb/qs@v6.14.0...v6.14.1) --- updated-dependencies: - dependency-name: qs dependency-version: 6.14.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* uncomment exit * better null check when normalizing schema
* normalize headers in components * update comment
Bumps [qs](https://github.com/ljharb/qs) from 6.14.0 to 6.14.1. - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md) - [Commits](ljharb/qs@v6.14.0...v6.14.1) --- updated-dependencies: - dependency-name: qs dependency-version: 6.14.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…Tools#22667) Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.6.0 to 2.6.3. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@2.6.0...2.6.3) --- updated-dependencies: - dependency-name: urllib3 dependency-version: 2.6.3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Also includes a fix for enums :)
…penAPITools#22634) * Add support for resolving the discriminator type from a 3.1 sibling * Set gradlew to be executable * Generate sample FILES again
…or override (OpenAPITools#22615) * Make GetAsync protected internal so external inheritors can override it * Remove non-zero token length requirement to allow more flexibility for token providers * Update samples
…ITools#22650) * [php][php-nextgen] Mark nullable things as nullable in phpdoc * [php][php-nextgen] Use exts instead of vendorExtensions
Bumps [qs](https://github.com/ljharb/qs) from 6.12.1 to 6.14.1. - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md) - [Commits](ljharb/qs@v6.12.1...v6.14.1) --- updated-dependencies: - dependency-name: qs dependency-version: 6.14.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#22679) * fix: test if return type is null before using it * chore: change sample example --------- Co-authored-by: Philippe Kernevez <philippe@kernevez.net>
Bumps [qs](https://github.com/ljharb/qs), [body-parser](https://github.com/expressjs/body-parser) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together. Updates `qs` from 6.14.0 to 6.14.1 - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md) - [Commits](ljharb/qs@v6.14.0...v6.14.1) Updates `body-parser` from 1.20.3 to 1.20.4 - [Release notes](https://github.com/expressjs/body-parser/releases) - [Changelog](https://github.com/expressjs/body-parser/blob/master/HISTORY.md) - [Commits](expressjs/body-parser@1.20.3...1.20.4) Updates `express` from 4.21.2 to 4.22.1 - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/v4.22.1/History.md) - [Commits](expressjs/express@4.21.2...v4.22.1) --- updated-dependencies: - dependency-name: qs dependency-version: 6.14.1 dependency-type: indirect - dependency-name: body-parser dependency-version: 1.20.4 dependency-type: indirect - dependency-name: express dependency-version: 4.22.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [Rust] Enum Query Parameter Serialization Fixes Adds tests to ensure this won't regress again. Also fixes some other compile errors with Box<> and file uploads. * Remove duplicate query param integration tests from petstore samples * re-gen samples * fix enum boxing tests * stream files * samples * doc generator fix & snapshot * doc generation fixes, update samples * another attempt to fix the doc generator * improve doc generation - don't try link to internal models, and fixing links missing in some scenarios the rust doc generator will be the death of me * also fix hyper * applying same fix to hyper * snapshot fixes
Bumps [qs](https://github.com/ljharb/qs) and [body-parser](https://github.com/expressjs/body-parser). These dependencies needed to be updated together. Updates `qs` from 6.13.0 to 6.14.1 - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md) - [Commits](ljharb/qs@v6.13.0...v6.14.1) Updates `body-parser` from 1.20.3 to 1.20.4 - [Release notes](https://github.com/expressjs/body-parser/releases) - [Changelog](https://github.com/expressjs/body-parser/blob/master/HISTORY.md) - [Commits](expressjs/body-parser@1.20.3...1.20.4) --- updated-dependencies: - dependency-name: qs dependency-version: 6.14.1 dependency-type: indirect - dependency-name: body-parser dependency-version: 1.20.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 4.1.0 to 4.1.1. - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@4.1.0...4.1.1) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 4.1.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ation to parameter of method toIndentedString (OpenAPITools#22685) * fix: add annotation to method parameter * fix: all impacted samples --------- Co-authored-by: Philippe Kernevez <philippe@kernevez.net>
…2577) * style(crystal): fix coding style * fix(crystal): object_id is so central in Crystal that it should not be overridden by user code See: https://crystal-lang.org/api/1.18.2/Reference.html#object_id%3AUInt64-instance-method * style(crystal): fix coding style * fix(crystal): fix partial_oneof_module by using a class instead of a module Fix OpenAPITools#22563 * fix(crystal): remove non-working code It's not working because it uses #send method which doesn't exist in Crystal See: https://crystal-lang.org/reference/1.18/crystal_for_rubyists/metaprogramming_help.html#differences-between-ruby-and-crystal * fix(crystal): update reserved words, separate reserved keywords from methods * fix(crystal): update samples * fix(crystal): set default values when options are not passed * fix(crystal): follow up OpenAPITools#22545 * fix(crystal): remove travis.yml file * style(crystal): fix coding style * style(crystal): use kwargs when calling @api_client * style(crystal): use kwargs when calling Crest::Request.new * fix(crystal): remove useless return_type argument * fix(crystal): map object type to JSON::Any type * fix(crystal): reduce use of require * fix(crystal): return early if value is nil * fix(crystal): update doc * fix(crystal): remove dead code * fix(crystal): kemal is not used in specs * fix(crystal): class name should be in PascalCase Fix: - class EnumAttributeValidatorFor_type < EnumAttributeValidator + class EnumAttributeValidatorForType < EnumAttributeValidator * fix(crystal): fix ameba warnings
Bumps [tar](https://github.com/isaacs/node-tar) from 7.5.3 to 7.5.6. - [Release notes](https://github.com/isaacs/node-tar/releases) - [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v7.5.3...v7.5.6) --- updated-dependencies: - dependency-name: tar dependency-version: 7.5.6 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [tar](https://github.com/isaacs/node-tar) from 7.5.3 to 7.5.6. - [Release notes](https://github.com/isaacs/node-tar/releases) - [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v7.5.3...v7.5.6) --- updated-dependencies: - dependency-name: tar dependency-version: 7.5.6 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [tar](https://github.com/isaacs/node-tar) from 7.5.3 to 7.5.6. - [Release notes](https://github.com/isaacs/node-tar/releases) - [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v7.5.3...v7.5.6) --- updated-dependencies: - dependency-name: tar dependency-version: 7.5.6 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [swift6][client] make PromiseKit as deprecated * [swift6][client] make PromiseKit as deprecated * [swift6][client] make PromiseKit as deprecated
* Fix HTML generator to display array types for body parameters The HTML generator (htmlDocs) was not properly displaying array types for request body parameters. When an endpoint accepted an array of objects as input, only the base type was shown (e.g., "User") instead of the full array type (e.g., "array[User]"). This fix updates the bodyParam.mustache template to include container type information (array, map, etc.) when present, matching the format already used for return types. Before: User After: array[User] The fix wraps the baseType with containerType[...] when isContainer is true, ensuring consistent type display across both input and output types in the generated HTML documentation. * Add html.yaml config and document testing requirements Due to network limitations in the automated build environment, the following steps could not be completed but are required per contribution guidelines: 1. Build project: ./mvnw clean install -DskipTests 2. Regenerate samples: ./bin/generate-samples.sh bin/configs/html.yaml 3. Commit updated samples: git add samples/documentation/html/ Added: - bin/configs/html.yaml: Configuration for html generator samples - TESTING_STEPS.md: Detailed instructions for completing the PR The template fix in bodyParam.mustache is complete and correct. Sample regeneration is needed to verify the fix visually in the generated HTML documentation. * Add concrete example showing the bug location in current HTML sample * Update HTML samples to verify array type fix Regenerated samples/documentation/html/index.html to verify the array type fix in bodyParam.mustache is working correctly. Verified fix: - Before: <div class="param">User <a href="#User">User</a> (required)</div> - After: <div class="param">User array[<a href="#User">User</a>] (required)</div> The createUsersWithArrayInput endpoint (and all array body parameters) now correctly displays "array[Type]" instead of just "Type". Also removed TESTING_STEPS.md as testing is now complete. * Update VERSION to 7.20.0-SNAPSHOT to match project version The samples were regenerated using npm's openapi-generator-cli (v7.4.0), but the CI expects the VERSION to match the current development version (7.20.0-SNAPSHOT). Updated to prevent CI failures. --------- Co-authored-by: Claude <noreply@anthropic.com>
* [swift6][client] make api calls concurrent * [swift6][client] improve swift 6 thread safety * [swift6][client] improve swift 6 thread safety
…concurrency (OpenAPITools#22802) * [swift6][client] Increase minimum supported SDK to accommodate swift concurrency * [swift6][client] Increase minimum supported SDK to accommodate swift concurrency
… swift 6 tests on CI (OpenAPITools#22805)
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.21...4.17.23) --- updated-dependencies: - dependency-name: lodash dependency-version: 4.17.23 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…21708 (OpenAPITools#21709) * feat(types): Add request configuration method to {{classname}}Interface * update docs and samples * refactor: change naming to better mirror openapi context * docs: update typescript-fetch
…penAPITools#22775) * [BUG][typescript-angular] apiKeys cause service compilation errors Updated TypeScript Angular `configuration.mustache` to properly handle apiKeys in query parameters by using `OpenApiHttpParams` instead of `HttpHeaders` to avoid compilation errors. Fixes OpenAPITools#22774 * add generated samples
* Add create requestOpts method to {{classname}}Interface OpenAPITools#21708 (OpenAPITools#21709)
* feat(types): Add request configuration method to {{classname}}Interface
* update docs and samples
* refactor: change naming to better mirror openapi context
* docs: update typescript-fetch
* feat(types): Add request configuration method to {{classname}}Interface
…penAPITools#22118) * Add HTTP client name to fix client duplicity * Fix samples
Update the Rust client generator template to use reqwest 0.13 instead of 0.12, as requested in issue OpenAPITools#22621. In reqwest 0.13, the `query()` and `form()` methods have been moved behind feature flags and are disabled by default. Since the generated Rust clients extensively use both methods, these features must be explicitly enabled. Changes: - Updated all reqwest dependencies from ^0.12 to ^0.13 - Added "query" and "form" to reqwest feature flags for all variants: - Blocking client configuration - Async client with file stream support - Async client without file stream - Reqwest-trait variant - Updated reqwest-middleware features for consistency This maintains full backward compatibility as only the dependency version and features change. The API surface of generated code remains identical. Fixes OpenAPITools#22621
In reqwest 0.13, the rustls-tls feature was renamed to rustls. This updates the Cargo.mustache template and all generated samples to use the new feature name, fixing CI build failures when using --all-features flag.
The previous reqwest-middleware 0.4 depends on reqwest 0.12, which caused type conflicts when upgrading to reqwest 0.13: - reqwest::Error (from reqwest 0.13) - reqwest_middleware::reqwest::Error (from reqwest 0.12 via middleware) These are different types from different versions of reqwest. reqwest-middleware 0.5 is compatible with reqwest 0.13, resolving the version conflict. With both using the same reqwest version, the re-exported types are now correctly aligned.
It adds "query" and "form" features for reqwest-middleware crate in petstore-async-middleware example and Cargo.mustache template.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)