-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
[Rust] Enum Query Parameter Serialization Fixes #22683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rust] Enum Query Parameter Serialization Fixes #22683
Conversation
Adds tests to ensure this won't regress again. Also fixes some other compile errors with Box<> and file uploads.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
13 issues found across 58 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="samples/client/petstore/rust/reqwest/petstore/tests/inline_enum_boxing_test.rs">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore/tests/inline_enum_boxing_test.rs:30">
P2: Test uses a tautological assertion that always passes, so it never validates the enum field behavior</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-async/tests/inline_enum_boxing_test.rs">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-async/tests/inline_enum_boxing_test.rs:30">
P2: Test assertion is a tautology, so the test always passes and cannot detect regressions.</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-async/src/apis/pet_api.rs">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-async/src/apis/pet_api.rs:573">
P2: upload_file now buffers entire file and loses reqwest file streaming/mime inference, risking large memory use and compatibility regressions</violation>
</file>
<file name="samples/client/others/rust/reqwest/multipart-async/docs/DefaultApi.md">
<violation number="1" location="samples/client/others/rust/reqwest/multipart-async/docs/DefaultApi.md:15">
P2: Documentation shows wrong function signature (missing async/Result and parameters) compared to generated API</violation>
<violation number="2" location="samples/client/others/rust/reqwest/multipart-async/docs/DefaultApi.md:27">
P2: Broken/misleading docs: `tags` type links `Vec<String>` to missing String.md, leaving a broken link</violation>
</file>
<file name="modules/openapi-generator/src/test/resources/3_0/rust/multipart-file-upload.yaml">
<violation number="1" location="modules/openapi-generator/src/test/resources/3_0/rust/multipart-file-upload.yaml:14">
P2: requestBody missing `required: true`, making required multipart file optional</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore/docs/ModelWithInlineEnum.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore/docs/ModelWithInlineEnum.md:10">
P3: Broken doc link: metadata property points to non-existent ModelWithInlineEnum_metadata.md instead of ModelWithInlineEnumMetadata.md</violation>
</file>
<file name="samples/client/others/rust/reqwest/multipart-async/src/apis/configuration.rs">
<violation number="1" location="samples/client/others/rust/reqwest/multipart-async/src/apis/configuration.rs:13">
P1: Deriving Debug on Configuration and ApiKey will log sensitive credentials (access tokens, API key, basic auth) if debug-printed, risking secret leakage.</violation>
</file>
<file name="samples/client/others/rust/reqwest/multipart-async/git_push.sh">
<violation number="1" location="samples/client/others/rust/reqwest/multipart-async/git_push.sh:42">
P2: Remote detection skips creating `origin` when another remote exists, causing subsequent `git pull/push origin` to fail if `origin` is absent.</violation>
<violation number="2" location="samples/client/others/rust/reqwest/multipart-async/git_push.sh:48">
P1: Credential is embedded into git remote URL, risking token leakage via .git/config, git remote output, or logs.</violation>
<violation number="3" location="samples/client/others/rust/reqwest/multipart-async/git_push.sh:53">
P2: Script hardcodes the `master` branch for pull/push, causing failures on repos whose default branch is `main` or another name.</violation>
<violation number="4" location="samples/client/others/rust/reqwest/multipart-async/git_push.sh:57">
P2: Pipeline masks git push exit status; script may report success on push failure (and vice versa).</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore/src/apis/pet_api.rs">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore/src/apis/pet_api.rs:499">
P2: File upload now buffers entire file in memory instead of streaming, causing potential OOM for large uploads</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
samples/client/others/rust/reqwest/multipart-async/src/apis/configuration.rs
Show resolved
Hide resolved
samples/client/petstore/rust/reqwest/petstore/tests/inline_enum_boxing_test.rs
Outdated
Show resolved
Hide resolved
samples/client/petstore/rust/reqwest/petstore-async/tests/inline_enum_boxing_test.rs
Outdated
Show resolved
Hide resolved
samples/client/petstore/rust/reqwest/petstore-async/src/apis/pet_api.rs
Outdated
Show resolved
Hide resolved
samples/client/petstore/rust/reqwest/petstore/src/apis/pet_api.rs
Outdated
Show resolved
Hide resolved
samples/client/petstore/rust/reqwest/petstore/docs/ModelWithInlineEnum.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 issues found across 11 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="samples/client/petstore/rust/reqwest/petstore-async/docs/ArrayItemRefTest.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-async/docs/ArrayItemRefTest.md:8">
P3: Doc link points to non-existent HashMap reference page (broken hyperlink).</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-async/docs/PropertyTest.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-async/docs/PropertyTest.md:7">
P2: Broken documentation link: Uuid__Uuid.md target does not exist anywhere in generated docs</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore/docs/TypeTesting.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore/docs/TypeTesting.md:13">
P2: Broken documentation link: `Uuid__Uuid.md` target does not exist in docs directory.</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-async/docs/TypeTesting.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-async/docs/TypeTesting.md:13">
P3: Documentation link for uuid type points to non-existent `Uuid__Uuid.md`, creating a dead link.</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore/docs/PropertyTest.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore/docs/PropertyTest.md:7">
P3: Documentation link targets a non-existent `Uuid__Uuid.md` file, resulting in a broken docs link for `uuid::Uuid`.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
samples/client/petstore/rust/reqwest/petstore-async/docs/PropertyTest.md
Outdated
Show resolved
Hide resolved
samples/client/petstore/rust/reqwest/petstore/docs/TypeTesting.md
Outdated
Show resolved
Hide resolved
samples/client/petstore/rust/reqwest/petstore-async/docs/ArrayItemRefTest.md
Outdated
Show resolved
Hide resolved
samples/client/petstore/rust/reqwest/petstore-async/docs/TypeTesting.md
Outdated
Show resolved
Hide resolved
samples/client/petstore/rust/reqwest/petstore/docs/PropertyTest.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 issues found across 140 files (changes from recent commits).
Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="samples/client/petstore/rust/reqwest/petstore-async-tokensource/docs/Pet.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-async-tokensource/docs/Pet.md:11">
P2: Documentation cross-reference removed: tags type no longer links to Tag.md, unlike other model fields.</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-avoid-box/README.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-avoid-box/README.md:68">
P3: README links point to non-existent model docs, resulting in broken documentation links</violation>
</file>
<file name="samples/client/petstore/rust/reqwest-trait/petstore/docs/ModelWithInlineEnum.md">
<violation number="1" location="samples/client/petstore/rust/reqwest-trait/petstore/docs/ModelWithInlineEnum.md:8">
P2: Documentation misstates enum fields as String instead of enum types, omitting allowed values</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-async-middleware/docs/ModelWithInlineEnum.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-async-middleware/docs/ModelWithInlineEnum.md:8">
P2: Documentation misrepresents inline enum fields: `status`/`priority` are enums in the model but documented as `String`.</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-async-tokensource/README.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-async-tokensource/README.md:46">
P2: README adds TestingApi endpoint links to docs/TestingApi.md, but that docs file does not exist, so the new links are broken.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
samples/client/petstore/rust/reqwest/petstore-async-tokensource/docs/Pet.md
Outdated
Show resolved
Hide resolved
samples/client/petstore/rust/reqwest-trait/petstore/docs/ModelWithInlineEnum.md
Outdated
Show resolved
Hide resolved
samples/client/petstore/rust/reqwest/petstore-async-middleware/docs/ModelWithInlineEnum.md
Outdated
Show resolved
Hide resolved
samples/client/petstore/rust/reqwest/petstore-async-tokensource/README.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
40 issues found across 95 files (changes from recent commits).
Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="samples/client/petstore/rust/reqwest/petstore-async-middleware/docs/UniqueItemArrayTesting.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-async-middleware/docs/UniqueItemArrayTesting.md:7">
P2: Documentation shows unique_item_array as Vec<String> but the generated model is HashSet<UniqueItemArray> enum, causing type mismatch and misleading guidance.</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-model-name-prefix/docs/FooModelWithInlineEnum.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-model-name-prefix/docs/FooModelWithInlineEnum.md:8">
P2: Docs misrepresent `status` field type; model uses `Status` enum, not `String`</violation>
<violation number="2" location="samples/client/petstore/rust/reqwest/petstore-model-name-prefix/docs/FooModelWithInlineEnum.md:9">
P2: Docs misrepresent `priority` field type; model uses `Priority` enum, not `Option<String>`</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-awsv4signature/docs/Pet.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-awsv4signature/docs/Pet.md:12">
P2: Documentation lists `status` as `Option<String>` but the generated model uses the `Status` enum; docs are incorrect/misleading</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-async-middleware/docs/EnumArrayTesting.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-async-middleware/docs/EnumArrayTesting.md:7">
P2: Documentation lists `required_enums` as `Vec<String>` but the model uses `Vec<RequiredEnums>` enum items (A, B, C)</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-avoid-box/docs/PropertyTest.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-avoid-box/docs/PropertyTest.md:7">
P2: Broken documentation link: `uuid::Uuid` points to missing `Uuid__Uuid.md`</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-async/docs/UniqueItemArrayTesting.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-async/docs/UniqueItemArrayTesting.md:7">
P2: Documentation lists unique_item_array as Vec<String> but the generated model field is HashSet<UniqueItemArray> (enum), making the doc inaccurate.</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-awsv4signature/docs/Order.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-awsv4signature/docs/Order.md:11">
P2: Documentation type mismatch: status is documented as Option<String> but the generated model uses Option<Status> enum.</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-avoid-box/docs/EnumArrayTesting.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-avoid-box/docs/EnumArrayTesting.md:7">
P2: Documentation type mismatch: `required_enums` is typed as `Vec<RequiredEnums>` in the model but documented as `Vec<String>`.</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-avoid-box/docs/ArrayItemRefTest.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-avoid-box/docs/ArrayItemRefTest.md:7">
P2: Broken documentation links added for standard container types (`Vec.md`, `Std__collections__HashMap.md`) that do not exist</violation>
<violation number="2" location="samples/client/petstore/rust/reqwest/petstore-avoid-box/docs/ArrayItemRefTest.md:8">
P2: Broken documentation links added for standard container types (`Vec.md`, `Std__collections__HashMap.md`) that do not exist</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-async-tokensource/docs/Order.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-async-tokensource/docs/Order.md:11">
P2: Documentation lists `status` as `Option<String>` while the model defines `status: Option<Status>` (enum), leading to incorrect guidance.</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-model-name-prefix/docs/FooUniqueItemArrayTesting.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-model-name-prefix/docs/FooUniqueItemArrayTesting.md:7">
P2: Documentation incorrectly describes `unique_item_array` as `Vec<String>` instead of the actual `HashSet<UniqueItemArray>` enum collection, misleading consumers about type and uniqueness guarantees.</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-awsv4signature/docs/PetApi.md">
<violation number="1">
P2: Documentation link targets missing String.md; new link for tags points to a non-existent file</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-async/docs/EnumArrayTesting.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-async/docs/EnumArrayTesting.md:7">
P2: Documentation lists required_enums as Vec<String>, but the model uses Vec<RequiredEnums> (enum A, B, C), so the documented type is wrong.</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-async-tokensource/docs/ModelWithInlineEnum.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-async-tokensource/docs/ModelWithInlineEnum.md:8">
P2: Documentation declares inline enum fields as String, but the generated Rust model uses concrete enums (Status, Priority), leading to type mismatch and misleading docs.</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-async/docs/Pet.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-async/docs/Pet.md:12">
P2: Documentation lists `status` as `Option<String>` but the Rust model uses an enum `Status`</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-async/docs/ModelWithInlineEnum.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-async/docs/ModelWithInlineEnum.md:8">
P2: Documentation lists enum fields as String instead of their actual enum types, diverging from the generated Rust model</violation>
<violation number="2" location="samples/client/petstore/rust/reqwest/petstore-async/docs/ModelWithInlineEnum.md:9">
P2: Doc lists `priority` as `Option<String>` though the model uses an enum `Priority`, leading to incorrect guidance</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-async-middleware/docs/Pet.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-async-middleware/docs/Pet.md:12">
P2: Documentation lists `status` as `Option<String>` but model uses `Option<Status>` enum, causing type mismatch between docs and code</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-async-tokensource/docs/UniqueItemArrayTesting.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-async-tokensource/docs/UniqueItemArrayTesting.md:7">
P2: Documentation lists wrong Rust type for unique_item_array (Vec<String> instead of HashSet<UniqueItemArray>)</violation>
</file>
<file name="samples/client/petstore/rust/reqwest-trait/petstore/docs/PetApi.md">
<violation number="1">
P2: Broken documentation link: `tags` type links to non-existent `String.md`</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-model-name-prefix/docs/FooArrayItemRefTest.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-model-name-prefix/docs/FooArrayItemRefTest.md:7">
P2: Newly added documentation link points to missing `Vec.md`, resulting in a broken link.</violation>
<violation number="2" location="samples/client/petstore/rust/reqwest/petstore-model-name-prefix/docs/FooArrayItemRefTest.md:8">
P2: Newly added documentation link points to missing `Std__collections__HashMap.md`, resulting in a broken link.</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-awsv4signature/docs/PropertyTest.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-awsv4signature/docs/PropertyTest.md:7">
P2: Added documentation link points to missing file `Uuid__Uuid.md`, creating a broken intra-doc link.</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-awsv4signature/docs/TypeTesting.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-awsv4signature/docs/TypeTesting.md:13">
P2: Broken documentation link to non-existent `Uuid__Uuid.md`</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-async/docs/PetApi.md">
<violation number="1">
P2: Broken documentation link: `Vec<String>` now links to non-existent `String.md`</violation>
</file>
<file name="samples/client/others/rust/reqwest-regression-16119/docs/Parent.md">
<violation number="1" location="samples/client/others/rust/reqwest-regression-16119/docs/Parent.md:7">
P2: New documentation link points to missing SerdeJson__Value.md, resulting in a broken type reference</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-model-name-prefix/docs/FooTypeTesting.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-model-name-prefix/docs/FooTypeTesting.md:13">
P2: Broken docs link: `Uuid__Uuid.md` target does not exist, rendering the new link invalid</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-async-tokensource/docs/TypeTesting.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-async-tokensource/docs/TypeTesting.md:13">
P2: Documentation link for `uuid::Uuid` points to non-existent `Uuid__Uuid.md`, creating a dead link.</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-avoid-box/docs/TypeTesting.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-avoid-box/docs/TypeTesting.md:13">
P2: Broken documentation link: `uuid::Uuid` points to missing `Uuid__Uuid.md`</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-async/docs/Order.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-async/docs/Order.md:11">
P2: Docs list `status` as Option<String> even though the model uses an enum type Option<Status>, causing a doc/code mismatch.</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-async-middleware/docs/PetApi.md">
<violation number="1">
P2: Broken documentation link: references `String.md` which is not present, leaving the `tags` type link dead.</violation>
</file>
<file name="samples/client/petstore/rust/reqwest-trait/petstore/docs/Order.md">
<violation number="1" location="samples/client/petstore/rust/reqwest-trait/petstore/docs/Order.md:11">
P2: Documentation lists `status` as `Option<String>` but the generated model uses an enum `Option<Status>`, causing doc/code mismatch.</violation>
</file>
<file name="samples/client/petstore/rust/reqwest-trait/petstore/docs/ModelWithInlineEnum.md">
<violation number="1" location="samples/client/petstore/rust/reqwest-trait/petstore/docs/ModelWithInlineEnum.md:8">
P2: Documentation lists `status` as `String` while the generated model uses the `Status` enum, causing a type mismatch in the public docs.</violation>
<violation number="2" location="samples/client/petstore/rust/reqwest-trait/petstore/docs/ModelWithInlineEnum.md:9">
P2: Documentation lists `priority` as `Option<String>` while the generated model uses `Option<Priority>` enum, misguiding SDK consumers.</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-model-name-prefix/docs/FooPet.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-model-name-prefix/docs/FooPet.md:12">
P2: Documentation lists `status` as `Option<String>` but the model uses the `Status` enum (`available|pending|sold`), causing a doc/type mismatch.</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-model-name-prefix/docs/UserApi.md">
<violation number="1">
P2: User list parameter links to non-existent User.md instead of FooUser.md, creating a broken model doc link</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-async-middleware/docs/TypeTesting.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-async-middleware/docs/TypeTesting.md:13">
P2: Broken documentation link: `Uuid__Uuid.md` target does not exist, resulting in a dead link for the uuid type</violation>
</file>
<file name="samples/client/petstore/rust/reqwest/petstore-awsv4signature/docs/EnumArrayTesting.md">
<violation number="1" location="samples/client/petstore/rust/reqwest/petstore-awsv4signature/docs/EnumArrayTesting.md:7">
P2: Documentation lists required_enums as Vec<String> but the generated Rust model uses Vec<RequiredEnums> enum</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
samples/client/petstore/rust/reqwest/petstore-async-middleware/docs/UniqueItemArrayTesting.md
Outdated
Show resolved
Hide resolved
samples/client/petstore/rust/reqwest/petstore-model-name-prefix/docs/FooModelWithInlineEnum.md
Outdated
Show resolved
Hide resolved
samples/client/petstore/rust/reqwest/petstore-model-name-prefix/docs/FooModelWithInlineEnum.md
Outdated
Show resolved
Hide resolved
samples/client/petstore/rust/reqwest/petstore-awsv4signature/docs/Pet.md
Outdated
Show resolved
Hide resolved
samples/client/petstore/rust/reqwest/petstore-async-middleware/docs/EnumArrayTesting.md
Outdated
Show resolved
Hide resolved
samples/client/petstore/rust/reqwest-trait/petstore/docs/ModelWithInlineEnum.md
Outdated
Show resolved
Hide resolved
samples/client/petstore/rust/reqwest-trait/petstore/docs/ModelWithInlineEnum.md
Outdated
Show resolved
Hide resolved
samples/client/petstore/rust/reqwest/petstore-model-name-prefix/docs/FooPet.md
Outdated
Show resolved
Hide resolved
samples/client/petstore/rust/reqwest/petstore-async-middleware/docs/TypeTesting.md
Outdated
Show resolved
Hide resolved
samples/client/petstore/rust/reqwest/petstore-awsv4signature/docs/EnumArrayTesting.md
Outdated
Show resolved
Hide resolved
…g links missing in some scenarios the rust doc generator will be the death of me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 114 files (changes from recent commits).
Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="samples/client/petstore/rust/hyper/petstore/src/apis/testing_api.rs">
<violation number="1" location="samples/client/petstore/rust/hyper/petstore/src/apis/testing_api.rs:71">
P2: Query param is JSON-encoded (adds quotes) instead of plain string, sending `%22value%22` for `status`.</violation>
</file>
<file name="samples/client/petstore/rust/hyper/petstore/docs/PetApi.md">
<violation number="1" location="samples/client/petstore/rust/hyper/petstore/docs/PetApi.md:184">
P2: Added documentation link points to non-existent `Page.md`, resulting in a broken reference</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
samples/client/petstore/rust/hyper/petstore/src/apis/testing_api.rs
Outdated
Show resolved
Hide resolved
|
@wing328 This is failing due to swift6 samples but regenerating them for me does not fix it... |
|
i'll take care of the sample update later, thanks for the quick fix |
Fixes issue mentioned here: #22281 (comment)
samples/client/others/rust/reqwest/enum-query-params/tests/query_param_integration_test.rsSummary by cubic
Fixes enum query parameter serialization across Rust reqwest and hyper clients so enums are sent as plain strings (not JSON-quoted), adds regression tests, and improves Rust docs with correct links and enum/uniqueItems types.
Bug Fixes
Dependencies
Written for commit ebf7367. Summary will update on new commits.