move most of the implementation of staticInvokables to core #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
changed the title
NullVoxPopuli
approved these changes
Mar 8, 2025
There was a problem hiding this comment.
Seems good -- had to compare with https://github.com/embroider-build/embroider/pull/2210/files to see that a good chunk of this PR is a revert of #2210
ef4
approved these changes
Mar 11, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't realise in #2210 what the implications of version drift would be splitting the deprecation and the default across two packages. This fixes that slight mess that I created 🙈 this effectively reverts the changes to
@embroider/compatthat provides any hint of the deprecation and handles it all in@embroider/core. This means that you won't get strange errors any more when you have a miss-match of versions 👍Edit: I moved all the cases where it would throw an error to core so they are now contained in one package but I still needed to accomidate the functionality in compat because of the implementation of
optionsWithDefaults(). I also bumped the minimum peer version of compat->core so that should help with the version skew 👍