Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate staticHelpers, staticModifiers, and staticComponents in favour of staticInvokables #2210

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

mansona
Copy link
Member

@mansona mansona commented Dec 14, 2024

No description provided.

@mansona mansona added the enhancement New feature or request label Dec 16, 2024
@mansona mansona changed the title Deprecate staticHelpers, staticModifiers, and staticComponents in favour of staticInvoakables Deprecate staticHelpers, staticModifiers, and staticComponents in favour of staticInvokables Jan 7, 2025
@ef4 ef4 merged commit d8fa8a7 into stable Jan 7, 2025
227 checks passed
@ef4 ef4 deleted the invokables branch January 7, 2025 14:43
@github-actions github-actions bot mentioned this pull request Jan 7, 2025
@miguelcobain
Copy link

In my v2 addon, I get the following error under the embroider-optimized scenario:

You cannot set `staticHelpers`, `staticComponents`, or `staticModifiers` if you have set `staticInvokables`. Delete these configs to continue.

However, I'm not defining these configs anywhere in my codebase.
I believe this is related to this PR.

Here is the failing CI run: https://github.com/miguelcobain/ember-yeti-table/actions/runs/12661940772/job/35286056334

Pinning the previous @embroider/compat version with

"resolutions": {
  "@embroider/compat": "3.7.1"
}

in the root package.json fixed the issue. Not sure what in my build was setting staticInvokables or anything related. 🤔

@gvdp
Copy link

gvdp commented Feb 5, 2025

Seeing the same failure in our CI run here: https://github.com/Bagaar/ember-graphql-mocking/actions/runs/13159870096/job/36725656239

Is there a good way to circumvent this? Maybe by setting these props manually in the embroiderOptimized() scenario?

@mansona
Copy link
Member Author

mansona commented Feb 5, 2025

the best way that I've seen to fix this is to re-roll your lock file. ember-try really shouldn't be using a lock file for any of this but making sure that you have the latest @embroider/core in your lock file fixes this problem 👍

@gvdp
Copy link

gvdp commented Feb 12, 2025

the best way that I've seen to fix this is to re-roll your lock file. ember-try really shouldn't be using a lock file for any of this but making sure that you have the latest @embroider/core in your lock file fixes this problem 👍

That worked, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants