Support "cache" from @glimmer/tracking #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
changed the title
NullVoxPopuli
commented
Jan 24, 2022
| @@ -20,7 +20,7 @@ class RedirectToEmber extends Plugin { | |||
| outputFileSync(join(this.outputPath, 'index.js'), `export { tracked } from '@ember/-internals/metal';`); | |||
| outputFileSync( | |||
| join(this.outputPath, 'primitives', 'cache.js'), | |||
| `export { createCache, getValue, isConst } from "@ember/-internals/metal";` | |||
| `export { cached, createCache, getValue, isConst } from "@ember/-internals/metal";` | |||
There was a problem hiding this comment.
@ef4 does this need to be in a macroCondition somehow? (exports have to be top-level don't they?) since pre ember-source-4.1, this cached export doesn't exist?
There was a problem hiding this comment.
I think you can write this in a way that isn't a SyntaxError even when cached is not exported by ember metal:
import * as metal from "@ember/-internals/metal";
const { cached, createCache, getValue, isConst } = metal;
export { cached, createCache, getValue, isConst };It means our module always exports the name cached, but on older ember its value will be undefined.
There was a problem hiding this comment.
will that work pre 3.27? I know some modules weren't allowing import *
I mean, I guess I'll find out!
|
Does this PR helps #1020 as well? |
|
@nightire I don't think so :( |
ef4
changed the title
|
Thanks, looking good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1086 (comment)