-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot import from @glimmer/tracking/primitives/cache
#1020
Comments
also occurs on ember-source ~4.0.0 |
Worth noting that this (failing) import is in a v2 addon ( I guess this might be related to I looked and debugged a bit into https://github.com/embroider-build/embroider/blob/master/packages/core/src/babel-plugin-adjust-imports.ts, especially this part. Don't know if that's relevant, unfortunately I was not able to draw any conclusions... Note that there are even more errors for different packages (see linked CI run above):
|
@ef4 are the compat adapters used for v2 addons? |
No, v2 addons don't run through the compat adapters. They exist to help convert v1 to v2. But if you're asking if a v2 addon that consumes a v1 addon will see the v1 addon after it has gone through a compat adapter, yes, it needs to work that way. |
@NullVoxPopuli Can't wait to use ember-resources@4 any longer 😭 |
I think this is resolved? @nightire you can use latest ember-resources with embroider now <3 |
Yes, I can confirm it works now, congrats! |
what was the fix again? I'm seeing |
Using
@embroider/test-setup
0.47.2ember-source
~3.28.0ember-cli-babel
^7.26.6And this code:
I'm getting this error:
build: https://github.com/NullVoxPopuli/ember-resources/runs/4205184397?check_suite_focus=true#step:5:145
The text was updated successfully, but these errors were encountered: