This repository has been archived by the owner on Mar 22, 2019. It is now read-only.
Adds a deprecation guide section about Ember.Select #2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
thanks! Please hold off on merging, I am going to re-tool the jsbin for clarity |
bantic
force-pushed
the
add-ember-select-deprecation-guide
branch
from
403c829
to
df479d5
Compare
bantic
force-pushed
the
add-ember-select-deprecation-guide
branch
from
df479d5
to
85a4bd9
Compare
| {{my-select content=myItems action=(action (mut mySelectedItem))}} | ||
| ``` | ||
|
|
||
| A more complete example of a `select` component that mimics the features of the deprecat Ember.Select is [available in this jsbin](http://emberjs.jsbin.com/fotuqa). |
mixonic
added a commit
that referenced
this pull request
Jun 11, 2015
Adds a deprecation guide section about Ember.Select
|
Fixed that line in a commit to master. |
|
👍 |
60 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of why
Ember.Selectis deprecated and notes on how modern Ember provides features that allow one to create the functionality ofSelectwithout the problematic aspects ofEmber.Select. Links to a jsbin showing amy-selectcomponent, a jsbin demonstrating usage of select without a component (but with Improved Actions) and links to Ember Observer's category page for "select" and the emberx-select addon) as migration suggestions.cc @mixonic
For #2256