Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Deprecate Ember.Select global #11416

Merged
merged 1 commit into from
Jun 11, 2015

Conversation

bantic
Copy link
Member

@bantic bantic commented Jun 11, 2015

Deprecates usage of Ember.Select global and references the Deprecations guide on the website (PR: emberjs/website#2201) for details.

refs #11377

@mixonic
Copy link
Member

mixonic commented Jun 11, 2015

Please add an @deprecated to the definition of the @class Select docs

@rwjblue
Copy link
Member

rwjblue commented Jun 11, 2015

👍

@@ -313,6 +313,7 @@ var SelectOptgroup = View.extend({
@namespace Ember
@extends Ember.View
@public
@deprecated See http://emberjs.com/deprecations/v1.x/#toc_ember-select
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mixonic Added @deprecated to the docs for Ember.Select

mixonic added a commit that referenced this pull request Jun 11, 2015
[BUGFIX beta] Deprecate Ember.Select global
@mixonic mixonic merged commit 469f4e8 into emberjs:master Jun 11, 2015
@mixonic mixonic deleted the deprecate-Ember-Select branch June 11, 2015 21:03
bantic added a commit to bantic/ember-legacy-views that referenced this pull request Jun 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants