-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Remove support for non-Octane blueprints #19894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rwjblue
merged 8 commits into
emberjs:master
from
cafreeman:cfreeman/remove-non-octane-blueprint-tests
Jan 12, 2022
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
02ebee3
controller test
cafreeman 29317a6
component test
cafreeman d3f28e8
component class test
cafreeman 1754cce
route test
cafreeman 965d2b3
route test
cafreeman b0c3e10
service test
cafreeman 4602942
remove pre-octane blueprints and fixtures
cafreeman 554e297
PR feedback
cafreeman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 0 additions & 1 deletion
1
blueprints/component-addon/native-files/__root__/__path__/__name__.js
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 0 additions & 1 deletion
1
blueprints/component-class-addon/native-files/__root__/__path__/__name__.js
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| import Controller from '@ember/controller'; | ||
|
|
||
| export default Controller.extend({ | ||
| }); | ||
| export default class <%= classifiedModuleName %>Controller extends Controller { | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,8 @@ | ||
| 'use strict'; | ||
|
|
||
| const useEditionDetector = require('../edition-detector'); | ||
|
|
||
| module.exports = useEditionDetector({ | ||
| module.exports = { | ||
| description: 'Generates a controller.', | ||
| normalizeEntityName: function (entityName) { | ||
| return entityName.replace(/\.js$/, ''); //Prevent generation of ".js.js" files | ||
| }, | ||
| }); | ||
| }; |
4 changes: 0 additions & 4 deletions
4
blueprints/controller/native-files/__root__/__path__/__name__.js
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,11 @@ | ||
| import Route from '@ember/routing/route'; | ||
|
|
||
| export default Route.extend({<% if (hasDynamicSegment) {%> | ||
| export default class <%= classifiedModuleName %>Route extends Route {<% if (hasDynamicSegment) {%> | ||
| model(params) { | ||
| /** | ||
| * This route was generated with a dynamic segment. Implement data loading | ||
| * based on that dynamic segment here in the model hook. | ||
| */ | ||
| return params; | ||
| },<%}%> | ||
| }); | ||
| }<%}%> | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 0 additions & 11 deletions
11
blueprints/route/native-files/__root__/__path__/__name__.js
This file was deleted.
Oops, something went wrong.
2 changes: 0 additions & 2 deletions
2
blueprints/route/native-files/__root__/__templatepath__/__templatename__.hbs
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| import Service from '@ember/service'; | ||
|
|
||
| export default Service.extend({ | ||
| }); | ||
| export default class <%= classifiedModuleName %>Service extends Service { | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,8 @@ | ||
| 'use strict'; | ||
|
|
||
| const useEditionDetector = require('../edition-detector'); | ||
|
|
||
| module.exports = useEditionDetector({ | ||
| module.exports = { | ||
| description: 'Generates a service.', | ||
| normalizeEntityName: function (entityName) { | ||
| return entityName.replace(/\.js$/, ''); //Prevent generation of ".js.js" files | ||
| }, | ||
| }); | ||
| }; |
4 changes: 0 additions & 4 deletions
4
blueprints/service/native-files/__root__/__path__/__name__.js
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.