Remove support for non-Octane blueprints #19894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cafreeman
force-pushed
the
cfreeman/remove-non-octane-blueprint-tests
branch
from
f273ca9 to
2fcb059
Compare
cafreeman
force-pushed
the
cfreeman/remove-non-octane-blueprint-tests
branch
2 times, most recently
from
85a184a to
e550b7d
Compare
cafreeman
force-pushed
the
cfreeman/remove-non-octane-blueprint-tests
branch
from
e550b7d to
4602942
Compare
locks
approved these changes
Jan 12, 2022
rwjblue
requested changes
Jan 12, 2022
| expect(_file('app/components/x-foo.js')).to.equal(fixture('component/component-dash.js')); | ||
| }); | ||
| // classic default | ||
| it('component-class foo --component-structure=classic --component-class=@ember/component', function () { |
Member
There was a problem hiding this comment.
Can you double check what the RFC says RE: "--component-structure=classic"? I think we probably don't need that flag value anymore...
Contributor
Author
There was a problem hiding this comment.
For anyone referencing this later, after discussing with @rwjblue we decided this would be fine in a separate PR.
rwjblue
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current blueprints test suite covers cases for both octane and non-octane blueprints, even though non-octane blueprints are no longer supported. As a result, this PR to upgrade ember-cli to 4.1.0 is blocked because all of the non-octane blueprint tests fail (since the CLI no longer generates non-Octane files).
This PR unblocks the ember-CLI upgrades by removing all of the non-Octane blueprint tests. In addition, it also removes all of the pre-Octane blueprints and fixtures since they are no longer supported and can't be generated in the current version of Ember CLI.