Set _qpDelegate before running code which could trigger _qpChanged #13981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dguettler
commented
Jul 31, 2016
dguettler
commented
- needs working test
… which could trigger _qpChanged
dguettler
changed the title
|
☔ The latest upstream changes (presumably #14414) made this pull request unmergeable. Please resolve the merge conflicts. |
rauhryan
added a commit
to huboard/huboard-web
that referenced
this pull request
Oct 6, 2016
rauhryan
added a commit
to rauhryan/ember.js
that referenced
this pull request
Oct 31, 2016
before mapping all the queryParams. In certain scenarios, if query params are shared through a service, bound query params will fire the _qpDelegate while transitioning to a new controller if the property has been modified from it's default value. Loosely related to - emberjs#11592 Based on a previous PR - emberjs#13981
rauhryan
added a commit
to rauhryan/ember.js
that referenced
this pull request
Nov 9, 2016
before mapping all the queryParams. In certain scenarios, if query params are shared through a service, bound query params will fire the _qpDelegate while transitioning to a new controller if the property has been modified from it's default value. Loosely related to - emberjs#11592 Based on a previous PR - emberjs#13981
rauhryan
added a commit
to huboard/huboard-web
that referenced
this pull request
Nov 14, 2016
chancancode
pushed a commit
that referenced
this pull request
Nov 27, 2016
before mapping all the queryParams. In certain scenarios, if query params are shared through a service, bound query params will fire the _qpDelegate while transitioning to a new controller if the property has been modified from it's default value. Loosely related to - #11592 Based on a previous PR - #13981 (cherry picked from commit 8f1db44)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.