`delegate is not a function`

[rlivsey]

I just updated our app to try the latest Canary and it appears to break query params for us.

We're seeing:

Error while processing route: xxx delegate is not a function TypeError: delegate is not a function

Here's the backtrace etc…

I'll see if I can reproduce in a smaller app asap.

[rwjblue]

I'll see if I can reproduce in a smaller app asap.

Definitely would be helpful.

[rlivsey]

Managed to reproduce in JSBin, it looks to be if the query param is a computed property:

http://emberjs.jsbin.com/dusufa

[rwjblue]

This might be related to moving the config to routes.

@trek / @machty - Could one of y'all take a look when you have a free minute?

[machty]

@rlivsey what's your use case for using a computed property as a QP's default value? I honestly don't expect that to work, and if it did before, it might have been an accident, but I'd like to understand how you are using it in your app.

[rlivsey]

My use-case is to display a formatted Date in the URL, so I was using a computed property for the string form:

const DATE_FORMAT = 'YYYY-MM';
export default Ember.Controller.extend({
   queryParams: {
     dateStr: "date"
   },

  date: null,

  dateStr: Ember.computed("date", {
    get() {
      const date = this.get("date");
      return date ? date.format(DATE_FORMAT) : null;
    },
    set(k, v) {
      this.set("date", window.moment.utc(v, DATE_FORMAT));
      return v;
    }
  })
});

I suppose instead I could instead invert this behaviour and instead of dateStr being the computed property I can make date set it instead:

  dateStr: null,

  date: Ember.computed("dateStr", {
    get() {
      const dateStr = this.get("dateStr");
      return dateStr ? window.moment.utc(dateStr, DATE_FORMAT) : null;
    },
    set(_, date) {
      this.set("dateStr", date ? date.format(DATE_FORMAT) : null);
      return date;
    }
  })

This works, but it would be nice to have the option to do it the other way. If using a CP for the value, it could just assume the default is null?

[amokan]

This has burned me on the 2.0.0 release as well. Had to revert back to 1.13.8 because I have a lot of this sort of thing going on.

[atsjj]

Thought I'd mention I just ran into this too. Similar story to @rlivsey...

[rlivsey]

I ran into this again the other day, similar use-case where I want the query string to reflect the current selected person in a list. The most straightforward approach is to simply alias the query param to the selected person's ID:

export default Ember.Controller.extend({
  queryParams: {
    selectedID: "selected"
  },
  selected: null,
  selectedID: Ember.computed.reads("selected.id")
});

That doesn't work, so now I'm forced to make this more complex and should also leave a comment to make sure a colleague doesn't try and refactor it back to the simpler version:

export default Ember.Controller.extend({
  queryParams: {
    selectedID: "selected"
  },  
  selectedID: null,

  // query params doesn't support computed properties, so set the ID manually
  // see issue for more details: https://github.com/emberjs/ember.js/issues/11592
  selected: Ember.computed({
    set(_, person) {
      this.set("selectedID", person ? person.get("id") : null),
      return person; 
    }
  })
});

[lolmaus]

Possibly related: #12102.

[kmiyashiro]

I am also getting this error after upgrading from 1.13.8 to 2.0.2. I'm not even using query param aliases and they are normal properties.

I noticed that it only occurs when I set the query params on('init', ...). This used to work fine in 1.13.x.

controller:

  queryParams: ['from', 'to', 'period', 'preset'],
  // Default date range
  preset: 'past 7 days',
  period: 'day',
  from: 0,
  to: 0,
...
  setDatesFromPreset: on('init', observer('preset',
    function setDatesFromPreset() {
      const preset = this.get('preset');
      const {
        from,
        to,
        period,
      } = ReportController.datePresetQueryParams(preset);

      if (!isNone(from) || !isNone(to)) {
        this.setProperties({
          period,
          _from: from,
          _to: to,
        });
      }

      this.set('toggleLabel', Ember.String.capitalize(preset));
    })
  ),

[lolmaus]

So are query params in Ember 2.x effectively broken? 😕

PS What's Canary in subj's title is now Stable.

[jcope2013]

having same issue