Remove usage of targetObject computed property.
#13755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the `targetObject` CP in favor of simply looking up the correct `targetObject` when needed. This simplifies the code path for `sendAction` and removes some overloading of the term "controller" (before this change it could mean an actual outlet's controller or the parentView.controller which may be a component and not a "real" controller).
Contributor
|
👍 |
Contributor
|
Do you think we can consolidate these?
|
Member
Author
|
@chadhietala - Possibly, I will review, might end up being a followup though... |
Contributor
|
Seems good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
targetObjectCP in favor of simply looking up the correcttargetObjectwhen needed. This simplifies the code path forsendActionand removes some overloading of the term "controller" (before this change it could mean an actual outlet's controller or the parentView.controller which may be a component and not a "real" controller).Fixes comments from @krisselden on the the
sendActionPR (#13745 / #13532)./cc @krisselden @chadhietala